Merge pull request #38294 from nextcloud/fix/37137/add-aria-expanded-…

…to-toggler-user-options Use aria-expanded correctly on toggle user actions
nextcloud · May 18, 2023 · c9aadb1 · c9aadb1
2 parents 1f9331e + a39f0de
commit c9aadb1
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/apps/settings/src/components/UserList/UserRow.vue b/apps/settings/src/components/UserList/UserRow.vue
@@ -250,6 +250,8 @@
 				</NcActions>
 				<div v-click-outside="hideMenu" class="userPopoverMenuWrapper">
 					<button class="icon-more"
+						:aria-expanded="openedMenu"
+						:aria-label="t('settings', 'Toggle user actions menu')"
 						@click.prevent="toggleMenu" />
 					<div :class="{ 'open': openedMenu }" class="popovermenu">
 						<NcPopoverMenu :menu="userActions" />

diff --git a/apps/settings/src/components/UserList/UserRowSimple.vue b/apps/settings/src/components/UserList/UserRowSimple.vue
@@ -69,9 +69,10 @@
 				<div class="userPopoverMenuWrapper">
 					<button v-click-outside="hideMenu"
 						class="icon-more"
+						:aria-expanded="openedMenu"
 						:aria-label="t('settings', 'Toggle user actions menu')"
 						@click.prevent="toggleMenu" />
-					<div class="popovermenu" :class="{ 'open': openedMenu }" :aria-expanded="openedMenu">
+					<div class="popovermenu" :class="{ 'open': openedMenu }">
 						<NcPopoverMenu :menu="userActions" />
 					</div>
 				</div>

diff --git a/dist/settings-users-8351.js b/dist/settings-users-8351.js
diff --git a/dist/settings-users-8351.js.map b/dist/settings-users-8351.js.map
diff --git a/dist/settings-vue-settings-apps-users-management.js b/dist/settings-vue-settings-apps-users-management.js
diff --git a/dist/settings-vue-settings-apps-users-management.js.map b/dist/settings-vue-settings-apps-users-management.js.map