Skip to content

Commit

Permalink
Correct aria-label on action input and text field
Browse files Browse the repository at this point in the history
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
  • Loading branch information
JuliaKirschenheuter committed Sep 27, 2023
1 parent f934d23 commit d09a946
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 6 deletions.
3 changes: 3 additions & 0 deletions apps/settings/src/components/GroupListItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
<NcActionInput v-if="id !== 'admin' && id !== 'disabled' && settings.isAdmin"
ref="displayNameInput"
icon="icon-edit"
:trailing-button-label="t('settings', 'Rename group')"
type="text"
:value="name"
:label=" t('settings', 'Rename group')"
Expand All @@ -61,10 +62,12 @@ import NcAppNavigationItem from '@nextcloud/vue/dist/Components/NcAppNavigationI
import NcCounterBubble from '@nextcloud/vue/dist/Components/NcCounterBubble.js'
import AccountGroup from 'vue-material-design-icons/AccountGroup.vue'
import NcTextField from '@nextcloud/vue/dist/Components/NcTextField'

Check failure on line 65 in apps/settings/src/components/GroupListItem.vue

View workflow job for this annotation

GitHub Actions / eslint

"@nextcloud/vue/dist/Components/NcTextField" is not found
export default {
name: 'GroupListItem',
components: {
NcTextField,

Check failure on line 70 in apps/settings/src/components/GroupListItem.vue

View workflow job for this annotation

GitHub Actions / eslint

Expected indentation of 2 tabs but found 1

Check failure on line 70 in apps/settings/src/components/GroupListItem.vue

View workflow job for this annotation

GitHub Actions / eslint

The "NcTextField" component has been registered but not used
AccountGroup,
NcActionButton,
NcActionInput,
Expand Down
3 changes: 3 additions & 0 deletions apps/settings/src/components/Users/UserRow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
<NcTextField ref="displayNameField"
data-test="displayNameField"
class="user-row-text-field"
:trailing-button-label="t('settings', 'Change display name')"
:class="{ 'icon-loading-small': idState.loading.displayName }"
:show-trailing-button="true"
:disabled="idState.loading.displayName || isLoadingField"
Expand All @@ -68,6 +69,7 @@
<template v-if="idState.editing && settings.canChangePassword && user.backendCapabilities.setPassword">
<NcTextField class="user-row-text-field"
:class="{'icon-loading-small': idState.loading.password}"
:trailing-button-label="t('settings', 'Add new password')"
:show-trailing-button="true"
:disabled="idState.loading.password || isLoadingField"
:minlength="minPasswordLength"
Expand All @@ -93,6 +95,7 @@
<NcTextField class="user-row-text-field"
:class="{'icon-loading-small': idState.loading.mailAddress}"
:show-trailing-button="true"
:trailing-button-label="t('settings', 'Add new email address')"
:disabled="idState.loading.mailAddress || isLoadingField"
:label="t('settings', 'Add new email address')"
trailing-button-icon="arrowRight"
Expand Down
4 changes: 2 additions & 2 deletions dist/settings-users-8351.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-users-8351.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/settings-vue-settings-apps-users-management.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-vue-settings-apps-users-management.js.map

Large diffs are not rendered by default.

0 comments on commit d09a946

Please sign in to comment.