Merge pull request #18349 from nextcloud/techdebt/deprecate-hooks-emi…

…tter-symfony-dispatcher Deprecate hooks, emitter and Symfony dispatcher mechanisms
nextcloud · Dec 11, 2019 · db44cc8 · db44cc8
2 parents 9a40ccf + 723f017
commit db44cc8
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 1 deletion.
diff --git a/lib/private/Hooks/BasicEmitter.php b/lib/private/Hooks/BasicEmitter.php
@@ -23,6 +23,9 @@
 
 namespace OC\Hooks;
 
+/**
+ * @deprecated 18.0.0 use \OCP\EventDispatcher\IEventDispatcher
+ */
 abstract class BasicEmitter implements Emitter {
 	use EmitterTrait;
 }
diff --git a/lib/private/Hooks/Emitter.php b/lib/private/Hooks/Emitter.php
@@ -30,6 +30,7 @@
  * interface for all classes that are able to emit events
  *
  * @package OC\Hooks
+ * @deprecated 18.0.0 use events and the \OCP\EventDispatcher\IEventDispatcher service
  */
 interface Emitter {
 	/**

diff --git a/lib/private/Hooks/PublicEmitter.php b/lib/private/Hooks/PublicEmitter.php
@@ -24,6 +24,9 @@
 
 namespace OC\Hooks;
 
+/**
+ * @deprecated 18.0.0 use events and the \OCP\EventDispatcher\IEventDispatcher service
+ */
 class PublicEmitter extends BasicEmitter {
 	/**
 	 * @param string $scope

diff --git a/lib/private/Server.php b/lib/private/Server.php
@@ -1848,6 +1848,7 @@ public function getCapabilitiesManager() {
 	 *
 	 * @return EventDispatcherInterface
 	 * @since 8.2.0
+	 * @deprecated 18.0.0 use \OCP\EventDispatcher\IEventDispatcher
 	 */
 	public function getEventDispatcher() {
 		return $this->query(\OC\EventDispatcher\SymfonyAdapter::class);

diff --git a/lib/private/legacy/hook.php b/lib/private/legacy/hook.php
@@ -28,7 +28,11 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>
  *
  */
-class OC_Hook{
+
+/**
+ * @deprecated 18.0.0 use events and the \OCP\EventDispatcher\IEventDispatcher service
+ */
+class OC_Hook {
 	public static $thrownExceptions = [];
 
 	static private $registered = array();