fix(settings): Use heading for Profile and Profile picture sections

Signed-off-by: Christopher Ng <chrng8@gmail.com>
nextcloud · Dec 22, 2023 · ee11df8 · ee11df8
1 parent 7d8741c
commit ee11df8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/apps/settings/src/components/PersonalInfo/AvatarSection.vue b/apps/settings/src/components/PersonalInfo/AvatarSection.vue
@@ -25,7 +25,7 @@
 		<h3 class="hidden-visually">
 			{{ t('settings', 'Your profile information') }}
 		</h3>
-		<HeaderBar :input-id="avatarChangeSupported ? inputId : null"
+		<HeaderBar :is-heading="true"
 			:readable="avatar.readable"
 			:scope.sync="avatar.scope" />
 
@@ -63,8 +63,7 @@
 					</NcButton>
 				</div>
 				<span>{{ t('settings', 'The file must be a PNG or JPG') }}</span>
-				<input :id="inputId"
-					ref="input"
+				<input ref="input"
 					type="file"
 					:accept="validMimeTypes.join(',')"
 					@change="onChange">
@@ -163,12 +162,6 @@ export default {
 		}
 	},
 
-	computed: {
-		inputId() {
-			return `account-property-${this.avatar.name}`
-		},
-	},
-
 	created() {
 		subscribe('settings:display-name:updated', this.handleDisplayNameUpdate)
 	},

diff --git a/apps/settings/src/components/PersonalInfo/ProfileSection/ProfileSection.vue b/apps/settings/src/components/PersonalInfo/ProfileSection/ProfileSection.vue
@@ -22,7 +22,7 @@
 
 <template>
 	<section>
-		<HeaderBar :readable="propertyReadable" />
+		<HeaderBar :is-heading="true" :readable="propertyReadable" />
 
 		<ProfileCheckbox :profile-enabled.sync="profileEnabled" />
 

diff --git a/dist/settings-vue-settings-personal-info.js b/dist/settings-vue-settings-personal-info.js
diff --git a/dist/settings-vue-settings-personal-info.js.map b/dist/settings-vue-settings-personal-info.js.map