fix: Check return type on rollback

Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Mar 13, 2023 · f00f424 · f00f424
1 parent 62e6a32
commit f00f424
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/apps/files_versions/lib/Versions/VersionManager.php b/apps/files_versions/lib/Versions/VersionManager.php
@@ -95,11 +95,14 @@ public function createVersion(IUser $user, FileInfo $file) {
 	public function rollback(IVersion $version) {
 		$backend = $version->getBackend();
 		$result = $backend->rollback($version);
-		\OC_Hook::emit('\OCP\Versions', 'rollback', [
-			'path' => $version->getVersionPath(),
-			'revision' => $version->getRevisionId(),
-			'node' => $version->getSourceFile(),
-		]);
+		// rollback doesn't have a return type yet and some implementations don't return anything
+		if ($result === null || $result === true) {
+			\OC_Hook::emit('\OCP\Versions', 'rollback', [
+				'path' => $version->getVersionPath(),
+				'revision' => $version->getRevisionId(),
+				'node' => $version->getSourceFile(),
+			]);
+		}
 		return $result;
 	}