Skip to content

Commit

Permalink
don't try to log the currently logged in user, this fails on cronjobs…
Browse files Browse the repository at this point in the history
…. The users are logged anyway
  • Loading branch information
schiessle committed Jun 20, 2016
1 parent e499630 commit f9fd709
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 31 deletions.
34 changes: 4 additions & 30 deletions apps/admin_audit/lib/actions/trashbin.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,41 +28,15 @@

class Trashbin extends Action {

/** @var IUserSession */
private $userSession;

/**
* Trashbin constructor.
*
* @param ILogger $logger
* @param IUserSession $userSession
*/
public function __construct(ILogger $logger, IUserSession $userSession) {
parent::__construct($logger);
$this->userSession = $userSession;
}

public function delete($params) {
$this->log('File "%s" deleted from trash bin by "%s"',
[
'path' => $params['path'],
'user' => $this->userSession->getUser()->getUID()
],
[
'path', 'user'
]
$this->log('File "%s" deleted from trash bin.',
['path' => $params['path']], ['path']
);
}

public function restore($params) {
$this->log('File "%s" restored from trash bin by "%s"',
[
'path' => $params['filePath'],
'user' => $this->userSession->getUser()->getUID()
],
[
'path', 'user'
]
$this->log('File "%s" restored from trash bin.',
['path' => $params['filePath']], ['path']
);
}

Expand Down
2 changes: 1 addition & 1 deletion apps/admin_audit/lib/auditlogger.php
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public function versionsHooks() {
* connect to trash bin hooks
*/
private function trashbinHooks() {
$trashActions = new Trashbin($this->logger, $this->userSession);
$trashActions = new Trashbin($this->logger);
Util::connectHook('\OCP\Trashbin', 'preDelete', $trashActions, 'delete');
Util::connectHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', $trashActions, 'restore');
}
Expand Down

0 comments on commit f9fd709

Please sign in to comment.