Persist the config changes of usermanagement

Persist the changes made to usermanagemnt like:

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>

apps/settings/lib/Controller/UsersController.php

@@ -260,6 +260,10 @@ public function usersList() {
 		$serverData['newUserGenerateUserID'] = $this->config->getAppValue('core', 'newUser.generateUserID', 'no') === 'yes';
 		$serverData['newUserRequireEmail'] = $this->config->getAppValue('core', 'newUser.requireEmail', 'no') === 'yes';
 		$serverData['newUserSendEmail'] = $this->config->getAppValue('core', 'newUser.sendEmail', 'yes') === 'yes';
+		$serverData['showLastLogin'] = $this->config->getAppValue('core', 'showlastlogin', 'no') === 'yes';
+		$serverData['showLanguages'] = $this->config->getAppValue('core', 'showlanguages', 'no') === 'yes';
+		$serverData['showUserBackend'] = $this->config->getAppValue('core', 'showuserbackend', 'no') === 'yes';
+		$serverData['showStoragePath'] = $this->config->getAppValue('core', 'showstoragepath', 'no') === 'yes';
 
 		return new TemplateResponse('settings', 'settings-vue', ['serverData' => $serverData]);
 	}
@@ -271,7 +275,7 @@ public function usersList() {
 	 * @return JSONResponse
 	 */
 	public function setPreference(string $key, string $value): JSONResponse {
-		$allowed = ['newUser.sendEmail'];
+		$allowed = ['newUser.sendEmail', 'showlastlogin', 'showlanguages', 'showuserbackend', 'showstoragepath'];
 		if (!in_array($key, $allowed, true)) {
 			return new JSONResponse([], Http::STATUS_FORBIDDEN);
 		}

apps/settings/src/views/Users.vue

@@ -235,27 +235,67 @@ export default {
 
 		// Local settings
 		showLanguages: {
-			get() { return this.getLocalstorage('showLanguages') },
-			set(status) {
-				this.setLocalStorage('showLanguages', status)
+			get() { return this.settings.showLanguages },
+			async set(value) {
+				try {
+					this.$store.commit('setServerData', {
+						...this.settings,
+						showLanguages: value,
+					})
+					await axios.post(generateUrl('/settings/users/preferences/showlanguages'), { value: value ? 'yes' : 'no' })
+				} catch (e) {
+					console.error('could not update last login preference: ' + e.message, e)
+				} finally {
+					this.showConfig.showLanguages = false
+				}
 			},
 		},
 		showLastLogin: {
-			get() { return this.getLocalstorage('showLastLogin') },
-			set(status) {
-				this.setLocalStorage('showLastLogin', status)
+			get() { return this.settings.showLastLogin },
+			async set(value) {
+				try {
+					this.$store.commit('setServerData', {
+						...this.settings,
+						showLastLogin: value,
+					})
+					await axios.post(generateUrl('/settings/users/preferences/showlastlogin'), { value: value ? 'yes' : 'no' })
+				} catch (e) {
+					console.error('could not update last login preference: ' + e.message, e)
+				} finally {
+					this.showConfig.showLastLogin = false
+				}
 			},
 		},
 		showUserBackend: {
-			get() { return this.getLocalstorage('showUserBackend') },
-			set(status) {
-				this.setLocalStorage('showUserBackend', status)
+			get() { return this.settings.showUserBackend },
+			async set(value) {
+				try {
+					this.$store.commit('setServerData', {
+						...this.settings,
+						showUserBackend: value,
+					})
+					await axios.post(generateUrl('/settings/users/preferences/showuserbackend'), { value: value ? 'yes' : 'no' })
+				} catch (e) {
+					console.error('could not update last login preference: ' + e.message, e)
+				} finally {
+					this.showConfig.showUserBackend = false
+				}
 			},
 		},
 		showStoragePath: {
-			get() { return this.getLocalstorage('showStoragePath') },
-			set(status) {
-				this.setLocalStorage('showStoragePath', status)
+			get() { return this.settings.showStoragePath },
+			async set(value) {
+				try {
+					this.$store.commit('setServerData', {
+						...this.settings,
+						showStoragePath: value,
+					})
+					await axios.post(generateUrl('/settings/users/preferences/showstoragepath'), { value: value ? 'yes' : 'no' })
+				} catch (e) {
+					console.error('could not update last login preference: ' + e.message, e)
+				} finally {
+					this.showConfig.showStoragePath = false
+				}
 			},
 		},
 

apps/settings/tests/Controller/UsersControllerTest.php

@@ -572,4 +572,23 @@ public function dataTestCanAdminChangeUserPasswords() {
 			[false, false, false, true],
 		];
 	}
+
+	public function dataSetPreference() {
+		return [
+			['newUser.sendEmail', 'yes', ['status' => 200]],
+			['showlastlogin', 'yes', ['status' => 200]],
+			['showlanguages', 'yes', ['status' => 200]],
+			['showuserbackend', 'yes', ['status' => 200]],
+			['showuserbackend', 'yes', ['status' => 200]],
+			['foobar', 'yes', ['status' => 403]],
+		];
+	}
+
+	public function testSetPreference(string $key, string $val, $expectedResult) {
+		$controller = $this->getController();
+
+		$result = $controller->setPreference($key, $val);
+
+		$this->assertEquals($expectedResult['status'], $result->getStatus());
+	}
 }