Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic share API to share files with apps #10292

Open
juliusknorr opened this issue Jul 19, 2018 · 7 comments
Open

Generic share API to share files with apps #10292

juliusknorr opened this issue Jul 19, 2018 · 7 comments

Comments

@juliusknorr
Copy link
Member

We are adding more and more share types to the server component for apps that need to share files depending on the apps data and ownership model.

Right now we have the following ones, that I think could also be moved to a common apps share:

  • SHARE_TYPE_GUEST
  • SHARE_TYPE_CIRCLE
  • SHARE_TYPE_ROOM

As it would also make sense for other apps like calendar, tasks or deck to access files and share them with users inside there, it would make sense to think about a common share type for apps.

Permission handling would need to be done by the app somehow. Should files that a user got access to by sharing though apps be visible in the file tree? If not, how can users access/download/edit it?

@nextcloud/sharing

@juliusknorr juliusknorr added enhancement feature: sharing 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 19, 2018
@juliusknorr
Copy link
Member Author

cc @danxuliu @daita since you are already integrating the file sharing with an additional app.

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #4159 (Shared API ), #3457 (Share by mail breaks File Sharing), #4193 (API for file details), #4456 (Search API: get all regular File infos along with share infos), and #7315 (Generic share and comments API).

@skjnldsv
Copy link
Member

@daita this is what your Entity pull request would implement, right?

@ArtificialOwl
Copy link
Member

@skjnldsv: yes, this is one of the thing that would be fixed by Entity

@skjnldsv skjnldsv added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 15, 2019
@szaimen

This comment has been minimized.

@juliusknorr
Copy link
Member Author

juliusknorr commented Jun 22, 2021

Would that be something covered by the planned circles work for 23 in server @ArtificialOwl ? I remember you mentioned app circle types

@ArtificialOwl
Copy link
Member

ArtificialOwl commented Jun 23, 2021

Would that be something covered by the planned circles work for 23 in server @ArtificialOwl ? I remember you mentioned app circle types

Yes, well not by using App SingleIds as they will be used if an app wants to generate its own grouping of users.
But yes, the future of Circles would be to replace all Share Types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants