📎 Add more sources to upload attachments

[jakobroehrl]

Is your feature request related to a problem? Please describe.
new button "camara" within the attachment section to make a photo and upload it directly as new attachment

Describe alternatives you've considered
Start the camara App manually, take a pic, open deck go to attachments, click the upload Button, search for the photo, add it

[desperateCoder]

Yep, that's a good one!

[stefan-niedermann]

Sure, makes sense. I guess we will have either an expandable floating action button or a bottom sheet like in whatsapp/telegram in the future.

[stefan-niedermann]

I have some troubles when receiving files which are not physically on the device yet.

I guess we have to store a local copy of the files in the app-directory and upload it from there, but i do not yet fully understand the concept of the DocumentProvider. Knowledge input or a Pull Request is welcome 🙂.

[q-wertz]

Maybe this is also related nextcloud/deck#564 and nextcloud/server#10292

[stefan-niedermann]

@jakobroehrl @q-wertz @splitt3r please have a look at this PR - It would be awesome if you could help testing the new stuff 🚀 🙂

[stefan-niedermann]

@jakobroehrl @q-wertz @splitt3r since you were interested in this issue, i'd like to ask you whether you are interested in testing some more improvements we've done before i release it as a beta? 🙂

Here is the APK to download and test - feedback is very welcome here.

[jakobroehrl]

wow! This is working awesome!

[q-wertz]

Looks amazing 🎉
My only problem was that on first sight I had trouble to find the camera. Might be more intuitive to not have it in the Gallery tab but in a separate one with own symbol?

[stefan-niedermann]

Hmm, did the upper left item (with the camera symbol) not display a live preview of the camera for you? (because it is black but it should display a live cam)

I orientated pretty much at the attachments picker of Telegram and it seemed to be pretty intuitive (for me at least 😆 )

[q-wertz]

It is black because it was covered 😆
So everything fine. Maybe just also had the wrong expectations from the previous version/other apps. 👍

[stefan-niedermann]

According to the material guidelines the bottom navigation (which we use) should only host up to 5 items - i planned to add one for audio one for video.

The concept idea is to have one picker per media type and each of the pickers shows a "primary / native" action + previews for quick access.

• camera + images
• native contact picker + direct contacts
• native file picker + downloaded files

and maybe in the future something like

• audio recorder + audio files
• video capturing + videos

But we for sure can still discuss this, maybe you have screenshots of some apps to compare with?

[stefan-niedermann]

The current state will be in version 1.12.0 (which is already tagged for F-Droid and available on Play Store beta channel).

Feel free to still discuss this feature in this or a new issue, but it "works as expected" and noone reported any bugs so far, so i thought: "let's get some more feedback from the community" 🙂

[aproposnix]

I don't mean to seem so pedantic but the rounded corners don't feel right when the menu is fully loaded with the round corners. Other than that, this is an awesome new feature.

[stefan-niedermann]

Indeed, i will have a look whether we can animate those corners :).

[q-wertz]

According to the material guidelines the bottom navigation (which we use) should only host up to 5 items - i planned to add one for audio one for video.

The concept idea is to have one picker per media type and each of the pickers shows a "primary / native" action + previews for quick access.

* camera + images

* native contact picker + direct contacts

* native file picker + downloaded files

and maybe in the future something like

* audio recorder + audio files

* video capturing + videos

But we for sure can still discuss this, maybe you have screenshots of some apps to compare with?

I think it makes sense to design it the way you said:+1:

Nevertheless, here are some screenshots how different messengers handle this (if you need some inspiration one day and maybe you don't have one of these 😉):

[jakobroehrl]

@stefan-niedermann
This is so awesome implemented.
Is there a change to implement this function in Android-talk, too?

[stefan-niedermann]

I am not aware of one, but i happily will have a talk with @AndyScherzinger and @tobiasKaminsky if they are interested to adapt the implementation 😉 It should be pretty portable and easy to adapt I think...

Merry christmas and stay well!