Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites and Shares icon in sidebar misaligned #10368

Closed
MorrisJobke opened this issue Jul 24, 2018 · 4 comments
Closed

Favorites and Shares icon in sidebar misaligned #10368

MorrisJobke opened this issue Jul 24, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@MorrisJobke
Copy link
Member

The icons for the categories "Favorites" and "Shares" are not there or at the wrong position.

bildschirmfoto 2018-07-24 um 11 17 34

cc @jancborchardt @skjnldsv @newhinton

Maybe because of #9982

@MorrisJobke MorrisJobke added design Design, UI, UX, etc. regression labels Jul 24, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Jul 24, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #6041 (Compact sidebar - icon only sidebar), #2308 (Missing delete option for email shares in the sidebar), #2277 (Sharing icon seems missing), #5911 ([stable12] Federated share icon is missing in Swedish translation), and #10308 (Shared folder icons and text is showed inconsistently).

@MorrisJobke MorrisJobke mentioned this issue Jul 24, 2018
21 tasks
@skjnldsv
Copy link
Member

I cannot reproduce :/
@nextcloud/designers

@MorrisJobke
Copy link
Member Author

The icons for the categories "Favorites" and "Shares" are not there or at the wrong position.

Not there was fixed in #10378

Now it looks like this in Safari:

bildschirmfoto 2018-07-25 um 09 36 37

Works fine in Firefox and Chrome. It is this transition rule:

#app-navigation .collapsible:before, #app-navigation .collapsible > a {
    transition: background 100ms ease-in-out, transform 250ms ease-in-out, opacity 100ms ease-in-out;
}

Once the part background 100ms ease-in-out is removed it works again on Safari as well.

@skjnldsv
Copy link
Member

Fix in #10386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants