Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix safari submenu navigation positionning #10386

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Fix safari submenu navigation positionning #10386

merged 1 commit into from
Jul 25, 2018

Conversation

skjnldsv
Copy link
Member

Fix #10368

@nextcloud/designers

@skjnldsv
Fix safari submenu navigation positionning
8e81bc7 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jul 25, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Jul 25, 2018
@skjnldsv skjnldsv self-assigned this Jul 25, 2018
@skjnldsv skjnldsv mentioned this pull request Jul 25, 2018
Closed
@MorrisJobke MorrisJobke mentioned this pull request Jul 25, 2018
Merged
21 tasks
juliusknorr
juliusknorr approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with IE, Chrome, Safari, FF 👍

MorrisJobke
MorrisJobke approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice- works 👍

@MorrisJobke MorrisJobke merged commit 90eced4 into master Jul 25, 2018
@MorrisJobke MorrisJobke deleted the bg-transition-safari-fix branch July 25, 2018 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @MorrisJobke @juliusknorr