Incorrect behavior of "Disabled users" tab

[1ndahous3]

Steps to reproduce

1. Empty "Disabled users" group
2. Go to "Users"-> "Disabled users"

Expected behaviour

Empty list of users

Actual behaviour

"Everyone" group was opened

Server configuration

Operating system: Debian Buster

Web server: Nginx/1.13.12

Database: 10.1.29-MariaDB-6+b1

PHP version: PHP 7.2.4-1+b2

Nextcloud version: 14.0.0 Beta 1

Updated from an older Nextcloud/ownCloud or fresh install: updated from 13.0.5

Signing status:

Signing status

No errors have been found.

List of activated apps:

App list

Enabled:
  - accessibility: 1.0.1
  - activity: 2.7.0
  - bookmarks: 0.11.0
  - bruteforcesettings: 1.1.0
  - calendar: 1.6.1
  - cloud_federation_api: 0.0.1
  - comments: 1.4.0
  - contacts: 2.1.5
  - dav: 1.6.0
  - federatedfilesharing: 1.4.0
  - federation: 1.4.0
  - files: 1.9.0
  - files_pdfviewer: 1.3.2
  - files_sharing: 1.6.2
  - files_texteditor: 2.6.0
  - files_trashbin: 1.4.1
  - files_versions: 1.7.1
  - files_videoplayer: 1.3.0
  - firstrunwizard: 2.3.0
  - gallery: 18.1.0
  - logreader: 2.0.0
  - lookup_server_connector: 1.2.0
  - mail: 0.8.3
  - nextcloud_announcements: 1.3.0
  - notifications: 2.2.1
  - oauth2: 1.2.1
  - ocsms: 1.13.1
  - password_policy: 1.4.0
  - phonetrack: 0.2.8
  - provisioning_api: 1.4.0
  - serverinfo: 1.4.0
  - sharebymail: 1.4.0
  - support: 1.0.0
  - survey_client: 1.2.0
  - systemtags: 1.4.0
  - theming: 1.5.0
  - twofactor_backupcodes: 1.3.0
  - updatenotification: 1.4.1
  - workflowengine: 1.4.0
Disabled:
  - admin_audit
  - checksum
  - encryption
  - files_external
  - groupfolders
  - metadata
  - spreed
  - tasks
  - user_external
  - user_ldap

Nextcloud configuration:

Config report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "14.0.0.13",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "updater.release.channel": "beta",
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: 61.0.1 (64-bit)

Operating system: Debian Stretch

Logs

Nextcloud log (data/nextcloud.log)

Nextcloud log

Empty

Browser log

Browser log

Empty

Screenshots:

[nextcloud-bot]

GitMate.io thinks possibly related issues are #3003 (Disable birthday contacts calendar generation for user), #283 (Ability to disable users), #4789 (Group admins cannot see disabled users), #10476 (Broken styles of results list in apps search), and #10491 (Restore button in "Deleted Files" tab doesn't work).

[weeman1337]

I think it is intended to hide the "Disabled users" if the list is empty. The redirect to all users is the fallback when calling the URL directly.

I'll fix the "Disabled users" hiding.