Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shares icon in high contrast theme #10742

Closed
splitt3r opened this issue Aug 18, 2018 · 8 comments · Fixed by #10773
Closed

Shares icon in high contrast theme #10742

splitt3r opened this issue Aug 18, 2018 · 8 comments · Fixed by #10773
Labels
bug design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Milestone

Comments

@splitt3r
Copy link
Contributor

I activated the high contrast theme and now the shares icon looks like this:

image

I´m running the nextcloud:beta Docker image with MariaDB.

@splitt3r
Copy link
Contributor Author

With dark mode enabled the arrow icon is black on black:

image

@nextcloud-bot nextcloud-bot added design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. labels Aug 18, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #5547 (When sharing "Upload Only" link, have theme background), #7704 (Icons missing after changing the theming color), #2277 (Sharing icon seems missing), #3146 (Theming: contrast improvements for certain color combinations), and #5157 (Icon inconsistency).

@splitt3r
Copy link
Contributor Author

The close button in the file select dialog is also not visible:

image

@oparoz
Copy link
Member

oparoz commented Aug 20, 2018

@skjnldsv - This is what we've talked about. It seems it doesn't work for everybody out of the box.

@skjnldsv
Copy link
Member

@oparoz the dark mode is in beta. So we're going to work on it but we're still going to have to grasp the whole compatibility thing with different setup and browsers.

@splitt3r
Copy link
Contributor Author

All in all it works pretty well already and i like it a lot :) just wanted to share some feedback.

@skjnldsv
Copy link
Member

@splitt3r Yes! thanks you very much! :D
Keep the feedback coming!

@skjnldsv
Copy link
Member

@jancborchardt regarding the opacity hack for the highcontrast theme, should we remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants