Theming: contrast improvements for certain color combinations

[jancborchardt]

So I came across this themed Nextcloud the other day:

• »Stay logged in« is white, even though the background is very light – so the text should be dark to provide proper contrast. Maybe the contrast algorithm has to be adjusted for yellow, because it’s a generally light color.
• The text & arrow of the log in button is black, even though the color of the .primary button is very dark. Text should be white hence. ;)

cc @nextcloud/theming

[eppfel]

Can not reproduce the Login Button issue.

[DJCrashdummy]

i experienced a similar issue (with the top-bar in the main view) and some other inconsistencies with theming:

i use a theme since owncloud 8.x with the main color #909091 (a kind of dark gray) and everything looks nice with a much brighter app- & user-name.

• last month i changed to nextcloud with the same theme installed and everything looks good but checkboxes and radiobuttons still a kind of "nextcloud-blue"!
• so i tried the theming-app and set #909091 as the color... checkboxes & radiobuttons went gray and additional the several nextcloud-favicons, but the app- & user-name went a kind of black (which don't looks as good as with the theme).
• and then i tried to combine them - i know it isn't recommended and the theming-app kind of detects it - but then things got "interesting"...
  the theming-app isn't accessible any more, although it overrides the theme and still controls the color of checkboxes, radiobuttons, the various nextcloud-favicons and obviously the app- & user-name since it stays black.
  update: also a other string (but still from the theme) is used for the site-title with theme and theming-app enabled.

beside the bugs which are at least partly mentioned at other issues, making the theming-app inaccessible isn't a reasonable solution since it controls the appearance of nextcloud. and beside that in my point of view the theme should override app-settings, since you must/should have more knowledge of how things work and what you are doing when using a theme.

maybe in future some triggers (either via theme or app) to chose which settings should be deciding would be useful, for some maybe use both theming-possibilities combined, since the colored favicons are nice but only available via theming-app.
--> this will lead to another problem because the colored nextcloud-icon is used by the app for generic sites (for sure also when a theme is enabled)...

by the way: the theming-app is also inaccessible and tells me You are already using a custom theme, although everything is still original or controlled by the theming-app, just because a non existent theme is specified in the config.php. :-/

[eppfel]

@DJCrashdummy Sry, no one replied, yet. But can you move this to a new issue? The real problem, it seems, is that the theming app interferes with the custom theme, which is a bug and has to be fixed.

[eppfel]

@DJCrashdummy I just saw there is a similar issue here #3094

[jonasgarstick]

We see the same behaviour like @jancborchardt with our own Nextcloud and other themed instances. No custom theming, just via the settings in the theming app.

[MorrisJobke]

Nothing for 12 -> move to 13.

[juliusknorr]

Fixed by the new login design, which works far nicer with theming.