Favicons for certain pages

[jancborchardt]

• Apps generally have their app icon as favicon – that’s good 👍
• Settings has the Nextcloud logo as favicon – that’s good 👍
• Files has the app icon too, file/folder – that’s ok, but since it’s the main part of Nextcloud it would be better if we show the Nextcloud logo too like for settings ❓ ☁️
• Share pages show the share icon, which is a bit strange. Normally you send these links to people who don’t even know Nextcloud – it should be the Nextcloud logo here too ☁️

What do you think @nextcloud/designers? @juliushaertl it seems to stem from autogenerating the favicon through the theming app, so do you know where to change this?

[nextcloud-bot]

GitMate.io thinks possibly related issues are #3821 (Customization of Personal page), #3193 (Detail pages for apps), #9252 (Wrong page rendering), #4295 (Missing sessions on Personal page), and #4020 (Search on public share pages).

[juliusknorr]

@jancborchardt Having the default logo for sharing pages makes sense to me. For the files app I'd rather keep the auto generated, since although it is the core app of Nextcloud it still is an app where it makes sense to separate from others in the tab list.

[pixelipo]

I agree with @juliushaertl

To add my 2 cents, I think at some point it should be possible to set the Default NC app in the Admin (or Personal?) settings to something other than the Files app, at which point it makes no sense whatsoever for the Files to have a default logo.

[jancborchardt]

@juliushaertl good point! Could you open a pull request to fix it for the sharing pages?

@pixelipo yup – the personal settings would be the right place for that. Although currently it’s an instance-wide config setting, so some work would need to be done. → Different issue in any case. :)