Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sessions on Personal page #4295

Closed
oparoz opened this issue Apr 11, 2017 · 11 comments
Closed

Missing sessions on Personal page #4295

oparoz opened this issue Apr 11, 2017 · 11 comments

Comments

@oparoz
Copy link
Member

oparoz commented Apr 11, 2017

Steps to reproduce

  1. Create app tokens
  2. Log in via the web
  3. Log in via the clients

Expected behaviour

All my sessions should be listed

Actual behaviour

Only the Web session is listed
The Apps Password section shows that there is activity with the tokens


@LukasReschke @icewind1991

@oparoz oparoz added the bug label Apr 11, 2017
@ChristophWurst
Copy link
Member

@oparoz do you mean active clients should be shown in the sessions section too?

@oparoz
Copy link
Member Author

oparoz commented Apr 11, 2017

I guess so since the description for "Sessions" says: "Web, desktop and mobile clients currently logged in to your account"

@ChristophWurst
Copy link
Member

Yeah well, to be precise it should be "desktop and mobile clients not using device-specific passwords". Not sure if we should show devices in the list of active sessions.

@oparoz
Copy link
Member Author

oparoz commented Apr 11, 2017

Ah, I see.

I think it makes sense to have everything under "Sessions", because in the future we may want to be able to kill them.

@oparoz oparoz added this to the Nextcloud 12.0 milestone May 17, 2017
@MorrisJobke
Copy link
Member

I think it makes sense to have everything under "Sessions", because in the future we may want to be able to kill them.

Yes - they need to be combined.

@MorrisJobke
Copy link
Member

And we should not show sessions of mobile phone and desktop because they are recreated automatically.

@ChristophWurst
Copy link
Member

I think it makes sense to have everything under "Sessions", because in the future we may want to be able to kill them.

PR at #5166 :)

And we should not show sessions of mobile phone and desktop because they are recreated automatically.

Please elaborate. Which sessions are you talking about here? IIRC we do list clients that support cookies, like our sync clients when they are configured to use the login password and not an app password.

@MorrisJobke
Copy link
Member

Please elaborate. Which sessions are you talking about here? IIRC we do list clients that support cookies, like our sync clients when they are configured to use the login password and not an app password.

Correct. The client uses sessions, but it also stores the app password (like the Android and iOS app) so when you "remove" that session via the web UI on the next request it will be recreated. Thus it is quite useless to show it. :/

@ChristophWurst
Copy link
Member

I see your point. I'll think about a possible solution. Maybe we need a new token type for that …

@MorrisJobke
Copy link
Member

I see your point. I'll think about a possible solution. Maybe we need a new token type for that …

Or oauth2 🙈 😉

@ChristophWurst
Copy link
Member

That's only a solution if we slowly deprecate HTTP basic auth IMO and have a clean migration path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants