NC14 broken - user_external files not replaced

[anolting]

hi,

I've downloaded the 14.0.3.zip, unpacked it, copied over my config.php and started the upgrade using CLi and got the follwing error:

sudo -u www-data php occ upgrade
Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Set log level to debug
Updating database schema
Updated database
UnexpectedValueException: The files of the app "user_external" were not correctly replaced before running the update
Update failed
Maintenance mode is kept active
Reset log level

I did this for the reason that my server unexpectedly stopped working after an web-based upgrade 7 or 8 days ago and wont start anymore.

Best
Alex

Steps to reproduce

1. Download the latest zip file nextcloud-14.0.3.zip
2. Unpack it
3. Copy over your config.php
4. run sudo -u www-data php occ upgrade

Expected behaviour

nextcloud should be upgraded

Actual behaviour

sudo -u www-data php occ upgrade
Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Set log level to debug
Updating database schema
Updated database
UnexpectedValueException: The files of the app "user_external" were not correctly replaced before running the update
Update failed
Maintenance mode is kept active
Reset log level

Server configuration

Operating system:
Ubuntu 14.04
Web server:
apache2
Database:
mysql
PHP version:
7.2.11
Nextcloud version: (see Nextcloud admin page)
14.0.3
Updated from an older Nextcloud/ownCloud or fresh install:
14.0.3 (upgraded 7 day before from 13.4 via webbased update)
Where did you install Nextcloud from:
https://download.nextcloud.com/server/releases/nextcloud-14.0.3.zip
Signing status:

Signing status

Login as admin user into your Nextcloud and access 
http://example.com/index.php/settings/integrity/failed 
paste the results here.

List of activated apps:

App list

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:

Config report

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or 

Insert your config.php content here. 
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Are you using external storage, if yes which one: local/smb/sftp/...

Are you using encryption: yes/no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

LDAP configuration (delete this part if not used)

LDAP config

With access to your command line run e.g.:
sudo -u www-data php occ ldap:show-config
from within your Nextcloud installation folder

Without access to your command line download the data/owncloud.db to your local
computer or access your SQL server remotely and run the select query:
SELECT * FROM `oc_appconfig` WHERE `appid` = 'user_ldap';


Eventually replace sensitive data as the name/IP-address of your LDAP server or groups.

Client configuration

Browser:

Operating system:

Logs

Web server error log

Web server error log

Insert your webserver log here

Nextcloud log (data/nextcloud.log)

Nextcloud log

[updater.log](https://github.com/nextcloud/server/files/2512170/updater.log)
[nextcloud.log](https://github.com/nextcloud/server/files/2512171/nextcloud.log)

Browser log

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

[nextcloud-bot]

GitMate.io thinks possibly related issues are #10863 (NC14 RC1 - Managing files), #12014 ((NC14 is broken) Can't update with GUI or manually), #6624 (Sensitive parameters are not fully replaced in log file), #6429 (Locked file), and #2331 (file upload conflict dialog broken).

[anolting]

Hi,

update: tried the cli upgrade procedure with the latest NC 15 and got the same error.

Best Alex

[anolting]

nextcloud_1.zip

[ghost]

Is there a fix?
Got the same issue for 15 Beta 1 from 14.x

[scurrvy2020]

I just disabled the user_external app and then I was able to proceed with the upgrade

occ app:disable user_external

[stefangweichinger]

I could upgrade as well but now get dozens of error messages

User backend OC_User_IMAP not found.

and can't install the user_external app from GUI or CLI

In Installer.php line 117:
                                                                                                                 
  App "External user support" cannot be installed because it is not compatible with this version of the server.

[duritong]

This is due to #12506 and can easily be fixed by changing the max version to 15 in apps/user_external/appinfo/info.xml

This seems to break quite some installation and it would be nice to have a 15.0.1 sooner than later.

Discussion to unbundle it and put it into the app store: nextcloud/user_external#22

[violoncelloCH]

exactly @duritong
Even though for 14.0.3 it should not have failed with the same error. Maybe there really happened something during @anolting 's update? But I don't really get it: in server configuration you write you were already on 14.0.3 but then tried to update to 14.0.3 manually by unpacking the zip...?

[anolting]

@violoncelloCH the description is a bit confusing as the web updater updated the version from 14.0.1 to 14.0.3 and for a couple of days everything seems fine. then the server stopped working and I tried a fresh manual installation from the zip. both installations showed the same error with the users_external app. I'm also wondering why the web based update didn't show in the first place this issue while updating?

[violoncelloCH]

@anolting thank you for clarifying
That's because the user_external app wasn't really maintained over the last time, but somehow it was still a shipped with a standard installation. Because of that, the updater didn't expect an issue with the user_external app. I'm one of the new maintainers and we will probably unbundle the user_external app and distribute releases via the appstore. But it's quite difficult to not generate further issues while doing that...
The strange thing with your issue is that it happened on 14.0.3 already. We're aware of the incompatibility-problem with 15.0.0, but with 14.0.3 nobody else seemed to have an issue.

[anolting]

Hi @violoncelloCH, just for info. I've downloaded the 14.0.3 zip file from different sources (official web page and github repo) and both showed the same problem.

[violoncelloCH]

The app is now released on the appstore - see https://apps.nextcloud.com/apps/user_external
can you test it with that?