Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file upload conflict dialog broken #2331

Closed
schiessle opened this issue Nov 25, 2016 · 7 comments
Closed

file upload conflict dialog broken #2331

schiessle opened this issue Nov 25, 2016 · 7 comments

Comments

@schiessle
Copy link
Member

schiessle commented Nov 25, 2016

Try to upload twice the same file so that the upload conflict dialog is shown. As you can see the dialog is broken on master (previews and checkboxes are not shown at the right place):

Firefox only, Chrome/Chromium is fine.

bug1

@MorrisJobke
Copy link
Member

Works here. (Maybe also give #2342 a try)

@nickvergessen
Copy link
Member

Broken here as well with Firefox, also #2342 doesn't help.

However works fine in Chromium with and without the patch.

@nickvergessen
Copy link
Member

@nextcloud/designers should be fixed before the 11 release

@MorrisJobke
Copy link
Member

After the recent fixes in #2342 I can't reproduce this anymore (only on small screens where those two elements doesn't fit beside each other).

@MorrisJobke
Copy link
Member

After the recent fixes in #2342 I can't reproduce this anymore (only on small screens where those two elements doesn't fit beside each other).

Tested in Firefox.

@nickvergessen
Copy link
Member

I just pulled master and the issue still exists for me.

The conflict div is 457px wide, both entries 230px. So they can not be displayed next to each other.

@MorrisJobke maybe it's because Firefox on iOS has a scrollbar which is much smaller?

@nickvergessen nickvergessen reopened this Nov 28, 2016
@MorrisJobke
Copy link
Member

@MorrisJobke maybe it's because Firefox on iOS has a scrollbar which is much smaller

Ah - possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants