The icon of new comment in the share is missing

[plyaskin]

Hi,
Could you add the icon of new comments in the shares?
Also the icon is missing anywhere at the recipient if the folder was shared.

1. Add a recipient to the shares
2. To comment from the sender. The sender is have, the recipient is not.
   

[nextcloud-bot]

GitMate.io thinks possibly related issues are #2277 (Sharing icon seems missing), #10877 (Comment icon is not shown on shared folder), #10583 (Icon "confirm-white" is missing), #10886 (NC14 RC1: unread comments icon with the Share User unvisible), and #4218 (Missing audio icon).

[skjnldsv]

@plyaskin Hey!
I'm not sure I get what you mean, the icon is shown when we have an unread comment, you want to add it all the time, having unread comment or not?

[rullzer]

@skjnldsv I could reproduce this (at least on master).

1. userA shares a folder to userB
2. userA adds a comment
3. userB refreses sees no comment
4. userB adds a comment
5. userA refresesh sees no comment

I could get it to show once. But in general it is not visible properly.

[skjnldsv]

@rullzer grid view?

[rullzer]

List view

[skjnldsv]

1. Create a folder as User0: ID is 198
2. Add comment as User0
3. Share folder to User1
4. As User1 check files: see folder. ID is 198

On load

User0 getNumberOfUnreadCommentsForFolder request the node ID 2
User1 getNumberOfUnreadCommentsForFolder request the node ID 191
🤔 First issue, we don't request the same ID

On the filecache database

The folder id is properly defined to 198, we also have a parent column which is set to 2
This is why it only works in a single direction, if User1 post a comment, User0 will have the icon, not the other way around

The getNumberOfUnreadCommentsForFolder join the comment table on the parent id (wtf is this?)

[skjnldsv]

More input, I get it now, we get all the unread comments of the content of the parent directory. Make sense.
Then this is the issue. The parent directory of the User1 is not the same as User0, therefore we cannot get the unread count! @rullzer