Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unread comment icon not shown for the sharee #12897

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Fix unread comment icon not shown for the sharee #12897

merged 2 commits into from
Dec 7, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Dec 6, 2018 •
edited by skjnldsv
Loading

Fix #12027

danxuliu and others added 2 commits December 6, 2018 18:31
@danxuliu
Add acceptance tests for comments on shared files and folders
6cee8ba 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@rullzer
If the parent is not cached we should request the file
d41d3d8 
Else we ignore all incomming shares. Which basically does 💥

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
skjnldsv
skjnldsv approved these changes Dec 7, 2018
View reviewed changes
apps/dav/lib/Connector/Sabre/CommentPropertiesPlugin.php
return 0;
} else {
return $this->getUnreadCount($node);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Dec 7, 2018
@skjnldsv
Copy link
Member

skjnldsv commented Dec 7, 2018

/backport to stable15

@skjnldsv
Copy link
Member

skjnldsv commented Dec 7, 2018

/backport to stable14

@skjnldsv
Copy link
Member

skjnldsv commented Dec 7, 2018

Timeout in apps unrelated!
Disable button in the app list for Auditing / Logging could not be found after 100 seconds (NoSuchElementException)

@skjnldsv skjnldsv added the high label Dec 7, 2018
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 7, 2018
@rullzer rullzer merged commit cfcce69 into master Dec 7, 2018
@rullzer rullzer deleted the fix-unread-comment-icon-not-shown-for-the-sharee branch December 7, 2018 14:07
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 7, 2018
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #12913

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 7, 2018
Merged
@backportbot-nextcloud
Copy link

backport to stable14 in #12914

@danxuliu danxuliu mentioned this pull request Dec 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@blizzz blizzz blizzz approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: comments feature: dav high
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
4 participants
@rullzer @skjnldsv @blizzz @danxuliu