Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard accessibility of personal settings Sessions menu #12243

Closed
jancborchardt opened this issue Nov 4, 2018 · 3 comments
Closed

Keyboard accessibility of personal settings Sessions menu #12243

jancborchardt opened this issue Nov 4, 2018 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: accessibility good first issue Small tasks with clear documentation about how and in which place you need to fix things in. help wanted
Milestone

Comments

@jancborchardt
Copy link
Member

This is about hte sessions/devices menu in the personal settings:

sessions now

The 3-dot menu needs to open on enter, and the Revoke button needs to work on enter too. (Filesystem access toggling works via Space, as is normal). I tried this in settings/js/authtoken_view.js but it does not work. cc @nextcloud/javascript

            $el.on('click', 'a.icon-delete', _.bind(this._onDeleteToken, this));
            this._deviceRevoke = $('a.icon-delete');
            this._deviceRevoke.on('keypress', function(event = key) {
                if (key === 13) {
                    console.log('Enter delete');
                    this._onDeleteToken(this);
                }
            }.bind(this));
 
            $el.on('click', '.icon-more', _.bind(this._onConfigureToken, this));
            this._deviceSettings = $('.icon-more');
            this._deviceSettings.on('keypress', function(event) {
                if (event === 13) {
                    console.log('Enter settings');
                    this._onConfigureToken(this);
                }
            }.bind(this));
@jancborchardt jancborchardt added bug help wanted design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of feature: accessibility labels Nov 4, 2018
@jancborchardt jancborchardt added this to the Nextcloud 15 milestone Nov 4, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #9994 (Keyboard accessibility), #9951 (Fix navigation keyboard accessibility), #10722 (Settings/user menu misaligned), and #12191 (Sessions fixes).

@MorrisJobke
Copy link
Member

Moved to 16.

@jancborchardt jancborchardt added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Mar 13, 2019
@rullzer rullzer modified the milestones: Nextcloud 17.0.4, Nextcloud 17.0.5 Mar 11, 2020
@rullzer rullzer modified the milestones: Nextcloud 17.0.5, Nextcloud 17.0.6 Mar 23, 2020
@jancborchardt
Copy link
Member Author

This was fixed some time ago by moving to the ActionMenu component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: accessibility good first issue Small tasks with clear documentation about how and in which place you need to fix things in. help wanted
Projects
None yet
Development

No branches or pull requests

4 participants