Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions fixes #12191

Merged
merged 6 commits into from
Nov 5, 2018
Merged

Sessions fixes #12191

merged 6 commits into from
Nov 5, 2018

Conversation

jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Nov 1, 2018

Fixes a bunch of things in the Sessions view in the personal settings (Security), including accessibility and this unnecessary tooltip:
delete tooltip for revoking devices

And this duplication of text in the tooltip:
device tooltips

Now looks like this:
sessions now

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
…uplication

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@rullzer
Copy link
Member

rullzer commented Nov 2, 2018

Would it be possible to break this down into small commits that we can get in quickly?

@jancborchardt
Copy link
Member Author

Would it be possible to break this down into small commits that we can get in quickly?

@rullzer are you being sarcastic? ;D I mean really, it is very broken down, no? Or do you want me to squash something? Or do you mean "broken down into small PRs"?

@rullzer
Copy link
Member

rullzer commented Nov 3, 2018

@jancborchardt I meant small PRs. I'm on a quest to get out PR count down. So ideally we can merge small fixes very quickly.

I know how it is when you start working on something... ooo and then I need to fix this as well. And this doesn't look right etc. And especially so close to the freeze I rather have everything in that we can ;)

So no sarcasm :)

@jancborchardt
Copy link
Member Author

We could also simply merge it at this stage. The keyboard enter-functionality could be done in a follow-up PR, but there’s nothing half-done here really. :)

@jancborchardt jancborchardt added 3. to review Waiting for reviews and removed 2. developing Work in progress help wanted labels Nov 4, 2018
@jancborchardt
Copy link
Member Author

Opened a separate issue for the keyboard enter accessibility at #12243

This is ready to review @nextcloud/designers :)

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@rullzer rullzer merged commit 41cace8 into master Nov 5, 2018
@rullzer rullzer deleted the sessions-fixes branch November 5, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants