-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sessions fixes #12191
Sessions fixes #12191
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
…uplication Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Would it be possible to break this down into small commits that we can get in quickly? |
@rullzer are you being sarcastic? ;D I mean really, it is very broken down, no? Or do you want me to squash something? Or do you mean "broken down into small PRs"? |
@jancborchardt I meant small PRs. I'm on a quest to get out PR count down. So ideally we can merge small fixes very quickly. I know how it is when you start working on something... ooo and then I need to fix this as well. And this doesn't look right etc. And especially so close to the freeze I rather have everything in that we can ;) So no sarcasm :) |
We could also simply merge it at this stage. The keyboard enter-functionality could be done in a follow-up PR, but there’s nothing half-done here really. :) |
Opened a separate issue for the keyboard enter accessibility at #12243 This is ready to review @nextcloud/designers :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
Fixes a bunch of things in the Sessions view in the personal settings (Security), including accessibility and this unnecessary tooltip:
And this duplication of text in the tooltip:
Now looks like this: