-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login image: option to display plain color instead #1414
Comments
@stephanedupont Thanks for your feature request. This is definitely something I'd like to add. I should have some time over the weekend to implement this. |
Yeah, makes sense. And it should be the main color then as used in the header – which is already used as fallback background color if the image can not be loaded.. @juliushaertl next to the file picker we could have a button saying »Plain color« (or just a button colored in that color with a tooltip, but not sure this is obvious enough). |
My idea was to add a button with icon-delete with the tooltip "Remove background image". I have a local dev branch with this feature that still need some bug fixing. I'll try to finish this over the week. |
As a workaround for others who find themselves here after searching for this topic, at least until this feature is available more conveniently in Nextcloud, what I do is generate a small (16x16) solid color image, upload that as the background image, and it is scaled to fill the background, thus providing a solid color background. |
@juliushaertl is this still feasible for 12? We plan to do the freeze mid next week. Otherwise I would move this to 13. |
@juliushaertl @Espina2 What do you think about the color nextcloud/nextcloud.com#434 in the header of this mockup? This would be easy to theme 🤔 |
@MorrisJobke Should be possible, I'll try to open a PR later today. @MariusBluem Sorry, but I don't get what what you mean in combination to this issue. 🤔 |
@juliushaertl I mean this as a login background (especially the color gradient) 😉 Could be easy to change the color over Theming 😏 |
@MariusBluem I like the idea although we don't have any other gradient anywhere in the server. Any other opinions @nextcloud/designers |
@MariusBluem I like the ideia, since I think our image on the server doesn't add any good, its just visual noise. :) |
Maybe we could also work with the 🌎-like design introduced on Nextclouds homepage (background) @Espina2 |
Done. #4617 |
This tempts admins into installing insecure packages to make the warning go away, even going so far as to [impurely modify running containers](nextcloud/docker#1414 (comment)). Changing the warning to trigger if the php-imagick module is loaded is more in line with the actual upstream recommendation, and hopefully helps unsuspecting users who have hacked around the warning in the past realize this. Draft because: - [ ] Untested (will try building this all this evening) - [ ] Translations are missing Band-aid for nextcloud#1414, while we wait for a proper solution with libvips or somesuch.
This tempts admins into installing insecure packages to make the warning go away, even going so far as to [impurely modify running containers](nextcloud/docker#1414 (comment)). Changing the warning to trigger if the php-imagick module is loaded is more in line with the actual upstream recommendation, and hopefully helps unsuspecting users who have hacked around the warning in the past realize this. Draft because: - [ ] Untested (will try building this all this evening) - [ ] Translations are missing, covered are: - [x] English - [x] German Band-aid for nextcloud#1414, while we wait for a proper solution with libvips or somesuch.
About the theme login image: it's really a nice feature! ... but shouldn't there be an option to display a plain color background instead of being force to display an image?
The text was updated successfully, but these errors were encountered: