File details will not change after redirecting from Favorites page

[ghost]

Steps to reproduce

1.Make sure there are at least two files.
2.Mark one of them as favorite.
3.Go to "Favorites" page, select the favorite file. Make sure the details view is open.
4.Click the "..." to show popup menu, click "View in folder".

5.Verify it redirects user to the All files page and the details is still showing.
6.Select a different file or click "Details", verify that the details view is not changed accordingly.

Expected behaviour

Should show the details of selected files.

Actual behaviour

The details does not change

Server configuration

Operating system:
CentOS 7 x86_64
Linux 10.211.55.9 3.10.0-327.el7.x86_64 #1 SMP Thu Nov 19 22:10:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Web server:
httpd-2.4.6-40.el7.centos.4.x86_64

Database:
sqlite3

PHP version:
PHP 5.4.16 (cli) (built: Aug 11 2016 21:24:59)

Nextcloud version: (see Nextcloud admin page)
Nextcloud 10.0 (stable)

Updated from an older Nextcloud/ownCloud or fresh install:

Where did you install Nextcloud from:

Signing status:

List of activated apps:

The content of config/config.php:

Are you using external storage, if yes which one: local/smb/sftp/...

Are you using encryption: yes/no
no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
no

Client configuration

Browser:
Firefox ESR 38.3.0

Operating system:
CentOS 7 x86_64

Logs

Web server error log

Nextcloud log (data/nextcloud.log)

Browser log

[nickvergessen]

If you manually close the sidebar, you see a second sidebar with the information you just clicked on. So I guess there is some destory magic missing.

@MorrisJobke do you have any idea about this?

[MorrisJobke]

@MorrisJobke do you have any idea about this?

Usually it should close the sidebar:

1. call to changeDirectory()

   server/apps/files/js/gotoplugin.js

   Line 44 in d623763

   OCA.Files.App.fileList.changeDirectory(fileModel.get('path'), true, true).then(function() {

2. that calls the reload() method:

   server/apps/files/js/filelist.js

   Line 1401 in 0ecaf8e

   return this.reload().then(function(success){

3. that then closes the sidebar:

   server/apps/files/js/filelist.js

   Line 1546 in 0ecaf8e

   this._updateDetailsView(null);

Let me debug this.

[MorrisJobke]

In this case following block is executed:

server/apps/files/js/filelist.js

Lines 490 to 496 in 0ecaf8e

	this._detailsView.setFileInfo(null);
	if (this._currentFileModel) {
	this._currentFileModel.off();
	}
	this._currentFileModel = null;
	OC.Apps.hideAppSidebar(this._detailsView.$el);
	return;

[MorrisJobke]

I just noticed that the sidebar element with the id sidebar exists twice. Let me check where this wrong element is added:

[MorrisJobke]

The element gets added when this line is executed:

server/apps/files/js/navigation.js

Line 106 in 5812273

this.$currentContent.trigger(jQuery.Event('show'));

[MorrisJobke]

The detailsview is added a second time here:

server/apps/files/js/filelist.js

Line 261 in 0ecaf8e

this._detailsView.$el.insertBefore(this.$el);

I think the detailsview should be destroyed on all changes between those different views.

[MorrisJobke]

I think the detailsview should be destroyed on all changes between those different views.

It looks like it is done, but somehow there is an issue in this:

server/apps/files/js/filelist.js

Line 355 in 0ecaf8e

this._detailsView.remove();

[MorrisJobke]

That's all I debugged - sorry I'm out - somehow the destroy method needs to be called to properly clean this up, but I have no proper insights into this to fix it. Maybe someone from @nextcloud/javascript could help out here :)