Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfocus of password input for share link should save password #15431

Closed
MorrisJobke opened this issue May 7, 2019 · 5 comments
Closed

Unfocus of password input for share link should save password #15431

MorrisJobke opened this issue May 7, 2019 · 5 comments
Labels

Comments

@MorrisJobke
Copy link
Member

Steps to reproduce

  1. Open Sharing UI for a folder
  2. Click "Add Link Share"
  3. Click "Add Password protection"
  4. Enter a password
  5. Leave the sharing UI. Normally all changes in Nextcloud are saved automatically when the input focus ist lost so the user can assume that it's the same with the password
  6. Open sharing UI again to verify that the password is saved -> it looks like the password has been saved correctly
  7. Only after reloading the page you can see that the password is lost (not saved).

Expected behaviour

  • password should be saved

Regression from NC 14. Reproducible in NC 15+

@nextcloud/javascript

@MorrisJobke MorrisJobke added this to the Nextcloud 15.0.8 milestone May 7, 2019
@skjnldsv
Copy link
Member

skjnldsv commented May 8, 2019

Iirc, this was removed on purpose, this is no mistake 🤔

EDIT: https://github.com/nextcloud/server/pull/12491/files#diff-da7df34db49581af77bd59e4f269dc36L57

@MorrisJobke
Copy link
Member Author

Iirc, this was removed on purpose, this is no mistake 🤔

On the other side there are some security implications if this is not clearly stated, that the unfocus does not save anymore. If people are used to this behavior they could get into trouble. Additionally we do not destroy the input on this close and it looks like the password is set properly when the user reopens the drop down menu.

@jancborchardt
Copy link
Member

Tend to agree with @MorrisJobke here. Changes should be saved automatically.

(And yeah, adding a "Save" button doesn’t really fix this cause even then people might forget or not see the save button and be frustrated too.)

@skjnldsv
Copy link
Member

Let's go for that then :)

@jancborchardt jancborchardt changed the title Unfocus of password input for share link should safe password Unfocus of password input for share link should save password May 22, 2019
@skjnldsv
Copy link
Member

Fixed with #15719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants