-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfocus of password input for share link should save password #15431
Comments
Iirc, this was removed on purpose, this is no mistake 🤔 |
On the other side there are some security implications if this is not clearly stated, that the unfocus does not save anymore. If people are used to this behavior they could get into trouble. Additionally we do not destroy the input on this close and it looks like the password is set properly when the user reopens the drop down menu. |
Tend to agree with @MorrisJobke here. Changes should be saved automatically. (And yeah, adding a "Save" button doesn’t really fix this cause even then people might forget or not see the save button and be frustrated too.) |
Let's go for that then :) |
Fixed with #15719 |
Steps to reproduce
Expected behaviour
Regression from NC 14. Reproducible in NC 15+
@nextcloud/javascript
The text was updated successfully, but these errors were encountered: