Force save share link password if click outside #17848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
rullzer,
georgehrke,
ChristophWurst and
juliusknorr
juliusknorr
approved these changes
Nov 7, 2019
rullzer
approved these changes
Nov 7, 2019
|
jsunit fails |
skjnldsv
force-pushed
the
fix/stable17/force-save-password-if-click-outside
branch
from
41f83a0 to
932a2c5
Compare
|
/compile amend /core/js |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
fix/stable17/force-save-password-if-click-outside
branch
from
932a2c5 to
d22cd50
Compare
skjnldsv
added
4. to release
skjnldsv
deleted the
fix/stable17/force-save-password-if-click-outside
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #15431
We fixed for 18, not for oldest versions. This is a simple patch in case a click outside is made with an unsaved password