Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-open popover on link password save failure #18551

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Re-open popover on link password save failure #18551

merged 1 commit into from
Jan 2, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 23, 2019 •
edited
Loading

After #17848

Peek 23-12-2019 12-07

@skjnldsv skjnldsv added this to the Nextcloud 17.0.3 milestone Dec 23, 2019
@skjnldsv skjnldsv self-assigned this Dec 23, 2019
@skjnldsv skjnldsv requested review from gary-kim and kesselb December 23, 2019 13:10
@gary-kim
Copy link
Member

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/sharing-link-password-failure branch from b6f3a59 to d07ec8e Compare December 23, 2019 13:23
@skjnldsv
Copy link
Member Author

@gary-kim hum, the edited script is not part of the compiled sources 🤔

@gary-kim
Copy link
Member

Oh no, not again

@skjnldsv
Copy link
Member Author

@gary-kim maybe the stable17 branch needed compile, let's wait for ci :)

@skjnldsv skjnldsv force-pushed the fix/sharing-link-password-failure branch from d07ec8e to b5253c4 Compare December 23, 2019 15:59
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 23, 2019
@skjnldsv
Copy link
Member Author

Tests fixed, no need to compile pls :p

@rullzer
Copy link
Member

rullzer commented Dec 27, 2019

@skjnldsv #18551 ci disagrees ;)

@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv
Re-open popover on link password save failure
a826176 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/sharing-link-password-failure branch from b5253c4 to a826176 Compare January 2, 2020 13:45
@skjnldsv skjnldsv merged commit 237cdb8 into stable17 Jan 2, 2020
@skjnldsv skjnldsv deleted the fix/sharing-link-password-failure branch January 2, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary-kim gary-kim gary-kim approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer rullzer approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
Milestone
Nextcloud 17.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @gary-kim @rullzer @juliusknorr