Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue contacts menu #15586

Closed
ChristophWurst opened this issue May 17, 2019 · 6 comments · Fixed by #40749
Closed

Vue contacts menu #15586

ChristophWurst opened this issue May 17, 2019 · 6 comments · Fixed by #40749

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented May 17, 2019

Is your feature request related to a problem? Please describe.

The contacts menu is plain old jQuery.

Describe the solution you'd like

I would like to replace that with a Vue component.

As per discussion below the contacts menu should actually get merged into the unified search: #15586 (comment)

Describe alternatives you've considered

n/a

Additional context

https://github.com/orgs/nextcloud/projects/31


@nextcloud/javascript @nextcloud/vue objections?

@ChristophWurst ChristophWurst added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap technical debt labels May 17, 2019
@rullzer
Copy link
Member

rullzer commented May 17, 2019

Do it :) IF there is an API to hook into it we should wrap and deprecate.
But moving this to something maintainable yes please!

@skjnldsv skjnldsv linked a pull request Aug 25, 2020 that will close this issue
@skjnldsv skjnldsv added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 25, 2020
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels Aug 18, 2021
@juliusknorr
Copy link
Member

@jancborchardt @nimisha-vijay I've been wondering if we could not just merge the contacts menu to the new unified search. Currently you can use both to search for contacts, just that the contacts menu also provides you with the actions immediately. I think having two ways for contacts doesn't make much sense:

image

image

The search currently does not search the system addressbook i think, so that could be something that would need to be extended as well.

@nimishavijay
Copy link
Member

Agreed, especially since it does show up in the unified search also, but without the actions.

@ChristophWurst
Copy link
Member Author

I've been wondering if we could not just merge the contacts menu to the new unified search

We also got this feedback from one of our customers. Makes sense IMO 👍

@blizzz
Copy link
Member

blizzz commented Sep 18, 2021

I've been wondering if we could not just merge the contacts menu to the new unified search

We also got this feedback from one of our customers. Makes sense IMO +1

Keep in mind that contacts menu allows different actions and we have apps for this (https://apps.nextcloud.com/apps/ldap_contacts_backend, https://apps.nextcloud.com/apps/telephoneprovider – given, the latter seems unmaintained), which the universal menu does not at the moment. This should be considered when replacing the contacts menu.

@ChristophWurst ChristophWurst moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Oct 3, 2023
@ChristophWurst ChristophWurst self-assigned this Oct 3, 2023
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Oct 3, 2023
@ChristophWurst
Copy link
Member Author

PR at #40749

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 4, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

7 participants