Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent files is missing entries #16876

Closed
juliushaertl opened this issue Aug 27, 2019 · 5 comments · Fixed by #22244
Closed

Recent files is missing entries #16876

juliushaertl opened this issue Aug 27, 2019 · 5 comments · Fixed by #22244
Labels
1. to develop Accepted and waiting to be taken care of bug
Milestone
Nextcloud 20

Comments

@juliushaertl
Copy link
Member

With #16424 some entries in the recent files might be missing. This issue is to keep track of further improving the situation:

This makes sure we do not get more than 3 times the limit we search for
or more than 5 queries.

This means we might miss some recent entries but we should fix that
separatly. This is just to make sure the load on the DB stays sane.

cc @rullzer
@juliushaertl juliushaertl added bug 1. to develop Accepted and waiting to be taken care of labels Aug 27, 2019
@rullzer

This comment has been minimized.

Sign in to view
@ChristophWurst

This comment has been minimized.

Sign in to view
@ChristophWurst

This comment has been minimized.

Sign in to view
@ChristophWurst ChristophWurst mentioned this issue Jun 3, 2020
Merged
1 task
@ChristophWurst
Copy link
Member

I actually have a patch but it is blocked currently by doctrine/dbal#3640

Updated in #21208

@ChristophWurst
Copy link
Member

@rullzer what is the plan with this?

rullzer added a commit that referenced this issue Aug 14, 2020
@rullzer
Improve recent file fetching
e59b084 
Fixes #16876

Before we'd just fetch everything from all storages we'd have access to.
Then we'd sort. And filter in php. Now this of course is tricky if a
user shared just a file with you and then has a ton of activity.

Now we try to contruct the prefix path. So that the filtering can happen
right away in the databae.

Now this will make the DB more busy. But it should help overall as in
most cases less queries are needed then etc.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer mentioned this issue Aug 14, 2020
Merged
rullzer added a commit that referenced this issue Aug 18, 2020
@rullzer
Improve recent file fetching
6ed4c8a 
Fixes #16876

Before we'd just fetch everything from all storages we'd have access to.
Then we'd sort. And filter in php. Now this of course is tricky if a
user shared just a file with you and then has a ton of activity.

Now we try to contruct the prefix path. So that the filtering can happen
right away in the databae.

Now this will make the DB more busy. But it should help overall as in
most cases less queries are needed then etc.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@MorrisJobke MorrisJobke added this to the Nextcloud 20 milestone Aug 18, 2020
kesselb pushed a commit that referenced this issue Aug 31, 2020
@rullzer @kesselb
Improve recent file fetching
1c8a678 
Fixes #16876

Before we'd just fetch everything from all storages we'd have access to.
Then we'd sort. And filter in php. Now this of course is tricky if a
user shared just a file with you and then has a ton of activity.

Now we try to contruct the prefix path. So that the filtering can happen
right away in the databae.

Now this will make the DB more busy. But it should help overall as in
most cases less queries are needed then etc.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging a pull request may close this issue.

Improve recent file fetching nextcloud/server
5 participants
@rullzer @nickvergessen @MorrisJobke @ChristophWurst @juliushaertl