New Folder Button on Filepicker Dialog (Type Choose)

[JonathanTreffler]

Is your feature request related to a problem? Please describe.
I am currently working on a PR to a nextcloud app called flowupload (e-alfred/flowupload#73).
In my PR you can chose the upload directory with a filepicker Dialog and it would be really useful to have a button to create a new folder.

This button exists on different filepicker Types (like OC.dialogs.FILEPICKER_TYPE_COPY):

... but not on OC.dialogs.FILEPICKER_TYPE_CHOOSE:

... it doesn't exist

Describe the solution you'd like
A button like on FILEPICKER_TYPE_COPY would be nice.

Additional context
This is the code i open the dialog with:

OC.dialogs.filepicker("Select a new Upload Folder", function(path) { ... }, false, 'httpd/unix-directory', true, OC.dialogs.FILEPICKER_TYPE_CHOOSE);

[kesselb]

server/core/src/OC/dialogs.js

Lines 301 to 304 in aa790a3

	var newButton = self.$filePicker.find('.actions.creatable .button-add')
	if (type === self.FILEPICKER_TYPE_CHOOSE) {
	newButton.hide()
	}

It seems the button is already there just hidden. I would try to make it visible. Probably a bit cleaner than making the button visible is to use FILEPICKER_TYPE_CUSTOM (not sure if available for Nextcloud 17) and push/trigger the choose action manually.

[kesselb]

cc @nextcloud/javascript opinions? I think it should be possible by using FILEPICKER_TYPE_CUSTOM but haven't tested it.

[JonathanTreffler]

Is there any reason the button is hidden ?

[kesselb]

Might be fixed by #19539

[JonathanTreffler]

Might be fixed by #19539

This change is in the branch stable19 and it does fix my problem 👍