Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to create directories when they are selectable #19539

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Allow to create directories when they are selectable #19539

merged 3 commits into from
Feb 25, 2020

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen nickvergessen added this to the Nextcloud 19 milestone Feb 19, 2020
@nickvergessen

This comment has been minimized.

Sign in to view
@nickvergessen nickvergessen added 2. developing Work in progress help wanted and removed 3. to review Waiting for reviews labels Feb 19, 2020
@nickvergessen

This comment has been minimized.

Sign in to view
@nickvergessen

This comment has been minimized.

Sign in to view
@nickvergessen nickvergessen mentioned this pull request Feb 19, 2020
Merged
2 tasks
@kesselb kesselb mentioned this pull request Feb 21, 2020
Closed
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 25, 2020
marcoambrosini
marcoambrosini approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@nickvergessen
Allow to create directories when they are selectable
22e748e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix "TypeError: u.$form is undefined"
4cc017d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy isFileNameValid function, so the filepicker works without the fi…
e053629 
…les app

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 25, 2020
@nickvergessen nickvergessen force-pushed the bugfix/noid/allow-to-create-directories-when-they-are-selectable branch from 5be1b5d to e053629 Compare February 25, 2020 11:01
@nickvergessen
Copy link
Member Author

Conflicting files
core/js/dist/login.js.map
core/js/dist/main.js.map
core/js/dist/maintenance.js
core/js/dist/maintenance.js.map

rebased

@nickvergessen nickvergessen merged commit 2ebf88a into master Feb 25, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/allow-to-create-directories-when-they-are-selectable branch February 25, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rummatee rummatee Awaiting requested review from rummatee

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: filepicker help wanted
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @ChristophWurst @juliusknorr @marcoambrosini