Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to select an attachment folder #2983

Merged
merged 4 commits into from
Feb 25, 2020
Merged

Allow to select an attachment folder #2983

merged 4 commits into from
Feb 25, 2020

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 19, 2020 •
edited
Loading

@nickvergessen nickvergessen added 3. to review enhancement feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Feb 19, 2020
@nickvergessen nickvergessen added this to the 💚 Next Major (19) milestone Feb 19, 2020
nickvergessen
nickvergessen commented Feb 19, 2020
View reviewed changes
docs/capabilities.md

## 9.0
* `config => attachments => allowed` - Whether the user can upload files into a chat
* `config => attachments => folder` - User defined folder where items should be uploaded to
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mario @Ivansss when you do upload, this is the folder where you should upload to.

@nickvergessen nickvergessen force-pushed the feature/noid/allow-to-select-attachment-folder branch from a4597a5 to 88a637a Compare February 21, 2020 12:58
@nickvergessen
Copy link
Member Author

Another chunk read @ma12-co lets get this in

@nickvergessen nickvergessen mentioned this pull request Feb 21, 2020
Merged
2 tasks
@nickvergessen
Allow to select an attachment folder
531b5a9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add a capability
0930c83 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Use the new attachment folder to upload files
2039dbf 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Try to create the target folder
d4383c1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/noid/allow-to-select-attachment-folder branch from 88a637a to d4383c1 Compare February 25, 2020 09:15
marcoambrosini
marcoambrosini approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

@nickvergessen nickvergessen merged commit 107dbf9 into master Feb 25, 2020
@nickvergessen nickvergessen deleted the feature/noid/allow-to-select-attachment-folder branch February 25, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@Ivansss Ivansss Awaiting requested review from Ivansss

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: settings ⚙️ Settings and config related issues feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v9.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @marcoambrosini