Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation screen: On button click, collapse details and show spinner correctly #2129

Closed
jancborchardt opened this issue Nov 15, 2016 · 6 comments · Fixed by #2242
Closed

Installation screen: On button click, collapse details and show spinner correctly #2129

jancborchardt opened this issue Nov 15, 2016 · 6 comments · Fixed by #2242
Assignees
@jancborchardt
Labels
design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 11.0

Comments

@jancborchardt
Copy link
Member

When clicking the install button while the Storage & database settings are open, the view looks really strange and the spinner is somewhere inbetween the text.

Instead, the advanced settings should collapse and then the spinner will be shown correctly on top of the user/password input fields.

cc @nextcloud/javascript especially because this is the first experience, we should fix it.
@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. labels Nov 15, 2016
@jancborchardt jancborchardt added this to the Nextcloud 11.0 milestone Nov 15, 2016
@MorrisJobke MorrisJobke mentioned this issue Nov 15, 2016
Closed
67 tasks
@jancborchardt
Copy link
Member Author

(As per #2134)

@skjnldsv
Copy link
Member

Screenshot? :D

@MorrisJobke
Copy link
Member

broken installer

@jancborchardt
Copy link
Member Author

Probably simply collapsing the details via JS will take care of the issue. Will investigate.

@jancborchardt jancborchardt self-assigned this Nov 21, 2016
@skjnldsv
Copy link
Member

Are you working on it @jancborchardt ? I can take a look on this tomorrow morning otherwise :)

jancborchardt added a commit that referenced this issue Nov 22, 2016
@jancborchardt
show installation spinner correctly, fix #2129
5688143 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt mentioned this issue Nov 22, 2016
Merged
@jancborchardt
Copy link
Member Author

Fix at #2242 :)

MorrisJobke added a commit that referenced this issue Nov 23, 2016
@MorrisJobke
Merge pull request #2242 from nextcloud/fix-installation-spinner
d342eed 
show installation spinner correctly, fix #2129
@MorrisJobke MorrisJobke removed the 1. to develop Accepted and waiting to be taken care of label Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jancborchardt jancborchardt

Labels
design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging a pull request may close this issue.

show installation spinner correctly, fix #2129 nextcloud/server
3 participants
@MorrisJobke @jancborchardt @skjnldsv