-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the file drop feature more obvious #2207
Comments
If you only want to change the wording, the string can be found here: server/core/js/sharedialoglinkshareview.js Line 340 in 7100a1b
(you can clone the nextcloud-server-repo, create a new branch, make and submit the changes and then create a pull request). |
I think a discussion needs to be had first as the wording was seemingly chosen for a reason, but I'd hope for a little more logic than just a wording change as outlined in the context thread on help.nc: https://help.nextcloud.com/t/filedrop-can-it-be-a-little-more-obvious/659/5?u=jasonbayton |
@jancborchardt We talked exactly about this during the hackweek ;) It's mentioned in the review of 11 as "Think about 'hide file listing'" - see #2134 @nextcloud/designers Any ideas how to make this more discoverable? Maybe also show this by default (when "Allow edit" is not ticked but then show it disabled?) |
@MorrisJobke might've been from my original post, as that was June 😄 Where clicking allow edit greys out the file drop option, similarly the opposite happens when file drop is clicked. and.. err.. this one too, but I make a lot of drop folders for media uploads after gigs, so I'm not sure how often the "normal" userbase would use this: |
@jasonbayton that seems good! I’d go first with the rewording in the share menu. Adding it to the »New« menu is a bit too much since the Collabora stuff is also in there. @nextcloud/javascript what do you think? |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
There’s a pull request for the wording at #2243 In addition, and what I also mentioned there, instead of the greying out which would be a bit confusing I propose:
This is probably something for Nextcloud 12 though because of the feature freeze. |
I'm game for radio buttons. But there'd need to be a read-only radio option too, since that's what shares are by default (and radio always defaults to one option) |
Right, also as you mentioned in the pull request. We need to go for a 3-option radio button. :) |
I'm not a big GH user, I may have accidentally commented on the PR and then realised it should be here! |
So what I suggest here, is to create page of upload instead of open the OS file manager. If we have another page its better to upload files from different folders and organize them. For example you have created a new empty folder and you want to upload files from multiple folders. Right now you have to upload one by one. In that new screen you can pretty easily show that you can drag and drop files. With that in mind people will get use to it and its normally to just drag and drop to window without going to the new page. Something like this (image from the internet I can make a mockup if you guys agree with me) What you think @jancborchardt @nextcloud/designers |
@jancborchardt I feel like I've helped make a positive minute change to NC11 ;) I'm looking forward to 12 though. I get the "allow upload and edit" then "upload only" appearing after, but I still think the radio buttons will make it truly intuitive. |
@Espina2 this issue is more about making the feature more obvious for people sending out the link, not receiving it. :) @jasonbayton you sure did! Thanks a lot for the feedback and keep it coming 😃 |
Implement the suggestions from #2207 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Implement the suggestions from #2207 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Implement the suggestions from #2207 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@jancborchardt We awaited some help here from you but the PR was closed in the meantime, because of inactivity: #3784 |
Don't leave us hanging @jancborchardt! |
So I don't see the changes in 12 beta for a radio button arrangement. Is it going to make the final? |
It wasn't finished in time. |
Bummer. Bring on 12.1! 🤣 |
I guess we will have no 12.1 ... the next one will be 13. 🤔 |
Implement the suggestions from #2207 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Fix for this is in #4681 |
Merged |
I wasn't aware initially when I installed NC the public filedrop option had been included until I read this article:
https://nextcloud.com/why-open-source-rocks/29
Then it took me a little while longer to actually be able to enable it as Google searches and document hunting on docs.nc led me nowhere.
It was only upon clicking "Allow editing" and "Hide file listing" out of sheer luck that I realised that's what it is..
Can this be made more obvious in a future update? Perhaps promote it as a public filedrop rather than wording it as hiding directory contents?
It'd be a little clearer.
Context:
https://help.nextcloud.com/t/filedrop-can-it-be-a-little-more-obvious/659
The text was updated successfully, but these errors were encountered: