Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text on 2FA page hard to read #2538

Closed
ChristophWurst opened this issue Dec 6, 2016 · 10 comments
Closed

Text on 2FA page hard to read #2538

ChristophWurst opened this issue Dec 6, 2016 · 10 comments
Assignees
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 6, 2016

On the two-factor page, "Log out" and "Use backup codes" are hard to read, especially on bright or contrasty backgrounds:
bildschirmfoto von 2016-12-06 22-04-35
bildschirmfoto von 2016-12-06 22-05-03

cc @nextcloud/designers

@ChristophWurst ChristophWurst added this to the Nextcloud 11.0 milestone Dec 6, 2016
@ChristophWurst ChristophWurst added the design Design, UI, UX, etc. label Dec 6, 2016
@Espina2
Copy link
Contributor

Espina2 commented Dec 6, 2016

I already post a solution for that here. #1615

@jancborchardt
Copy link
Member

We need to simply experiment with the opacity of the black container, make it less transparent. Unfortunately the CSS blur function isn't really there yet cross-browser cause that would be perfect here. cc @nextcloud/designers

(@Espina2 not sure why you keep mentioning that complete overhaul. It would be more helpful to propose fixes issue-specifically instead of making one big change mainly for the sake of change.)

@jancborchardt
Copy link
Member

@ChristophWurst regarding the other text below, can you put that inside of the container?

@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Dec 8, 2016
@skjnldsv
Copy link
Member

skjnldsv commented Dec 8, 2016

@jancborchardt svg blur are supported by all browsers! ;)
http://caniuse.com/#feat=svg-filters

https://jsfiddle.net/yUG5U/1304/

@Espina2
Copy link
Contributor

Espina2 commented Dec 9, 2016

I mention that because one of the changes proposed in that issue is for this particular case.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 9, 2016

@Espina2 could you point it precisely? Because the other thread is kind has kind of too much data! 😆

@jancborchardt
Copy link
Member

@skjnldsv do we want to go for that then? And put the other text items below (except the footet) in the container?

@Henni
Copy link
Member

Henni commented Dec 9, 2016

What do we gain from blur, in case of the "worst case scenario" (a completely white background)?

@skjnldsv
Copy link
Member

skjnldsv commented Dec 9, 2016

@Henni a more or less smooth area in terms of saturation and colours :)

ChristophWurst added a commit that referenced this issue Dec 12, 2016
Fixes #2538

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Dec 12, 2016
@ChristophWurst ChristophWurst removed their assignment Dec 12, 2016
@jancborchardt
Copy link
Member

@Henni blur will improve the readability of the text because regardless of what’s in the background, the sharpness and noise will be reduced. Currently we use the only slightly transparent dark container to achieve a similar result, but additional blur is even more elegant.

@skjnldsv skjnldsv self-assigned this Jan 25, 2017
ChristophWurst added a commit that referenced this issue Feb 6, 2017
Fixes #2538

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
None yet
Development

No branches or pull requests

7 participants