Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the update banner does not open a new window #273

Closed
ungesundes-halbwissen opened this issue Jul 1, 2016 · 4 comments
Closed
Labels
enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@ungesundes-halbwissen
Copy link

Clicking the update banner at the top reading: "Nextcloud ...is available. Get more information on how to update" opens a page in the documentation where one can learn about how to update.

This page opens in the very same window I run Nextcloud in. It would be better to open this link in a new target window in order not to have to navigate to get my Nextcloud window back.

@MorrisJobke MorrisJobke added enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Jul 1, 2016
@Faldon
Copy link
Contributor

Faldon commented Jul 4, 2016

I was just checking the responsible file. I assume it's notification.js from apps/updatenotification/js.
According to the code, the link already generated with target '_blank':
element = $('<a>').attr('href', docLink).attr('target','_blank').text(text);

My personal cloud is up-to-date in the version 8 branch, but if I run the javascript in the console (I tested Chrome and Firefox) and click the notification banner, the link is opened in a new window/tab as expected.

@ungesundes-halbwissen
Copy link
Author

Thx for checking @Faldon
I double checked as well and for me the behavior is reproducible. Running NC 9.0.51 using Firefox
Please check the screenshot enclosed (Note, that the system language is set to German, but the upgrade notice is still showing up in English, despite an existing translation.
The element also seems to be missing the target="_blank" parameter you mentioned
nc9 0 51

@Faldon
Copy link
Contributor

Faldon commented Jul 4, 2016

@ungesundes-halbwissen I'm fine with German. :-) I will set up a development server in the evening and try to find out, if the aforementioned JavaScript file is really responsible for creating the update notification.

@schiessle
Copy link
Member

fix was merged. Thanks @Faldon for debugging and fixing it!

@MorrisJobke MorrisJobke added this to the Nextcloud Next milestone Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

4 participants