Changed the creation of the update notification link #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js object from concated string.
|
@Faldon, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @MorrisJobke and @LukasReschke to be potential reviewers |
| @@ -18,7 +18,7 @@ $(document).ready(function(){ | |||
| version = oc_updateState.updateVersion, | |||
| docLink = oc_updateState.updateLink, | |||
| text = t('core', '{version} is available. Get more information on how to update.', {version: version}), | |||
| element = $('<a>').attr('href', docLink).attr('target','_blank').text(text); | |||
| element = $('<a href="'+docLink+'" target="_blank">'+text+'</a>'); | |||
There was a problem hiding this comment.
Please make sure to have text and docLink escaped in this cases then using escapeHTML.
|
Tested and works 👍 Code looks good |
|
looks good 👍 |
|
Great stuff @Faldon, will add you to the organization and the Javascript team. :) |
|
@jancborchardt With pleasure. I finally thought, it's time to contribute back. That's the point in OSS. |
|
@Faldon welcome to Nextcloud then! :) Very much looking forward to future contributions. |
|
🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of chaining the DOM manipulation commands, create an object from a concatenated string.
Solves #273