Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the creation of the update notification link #309

Merged
merged 2 commits into from
Jul 5, 2016
Merged

Changed the creation of the update notification link #309

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f173ced
Changed the creation of the update notification link to generate the …
Faldon Jul 4, 2016
601c5b8
Added escaping html code when building link to documentation.
Jul 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/updatenotification/js/notification.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ $(document).ready(function(){
version = oc_updateState.updateVersion,
docLink = oc_updateState.updateLink,
text = t('core', '{version} is available. Get more information on how to update.', {version: version}),
element = $('<a>').attr('href', docLink).attr('target','_blank').text(text);
element = $('<a href="'+docLink+'" target="_blank">'+text+'</a>');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to have text and docLink escaped in this cases then using escapeHTML.


OC.Notification.showTemporary(
element,
Expand Down