Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No email suggestion when sharing with IDN email address #30595

Closed
PVince81 opened this issue Jan 11, 2022 · 0 comments · Fixed by #30600
Closed

No email suggestion when sharing with IDN email address #30595

PVince81 opened this issue Jan 11, 2022 · 0 comments · Fixed by #30600
Labels
1. to develop Accepted and waiting to be taken care of bug feature: sharing

Comments

@PVince81
Copy link
Member

Steps

  1. Create a folder
  2. Open the right sidebar
  3. Type an email address like "test@example.com" and wait
  4. Then change it to "test@äxample.com" and wait

Expected result

In both 3 and 4 an entry with an envelope must appear in the dropdown.

Actual result

Only in case 3 without the umlaut the entry with the envelope appears.

Versions

Observed on 22.2.3 and master

I've tried with this IDN fix of the backend #27961 but it didn't solve the problem.
I suspect that there's also some JS code in the frontend that tried to detect email addresses and will need to be adjusted.
@PVince81 PVince81 added bug 1. to develop Accepted and waiting to be taken care of feature: sharing labels Jan 11, 2022
CarlSchwan added a commit that referenced this issue Jan 11, 2022
@CarlSchwan
Fix idn emails not working in shares
d4a5e48 
Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan mentioned this issue Jan 11, 2022
Merged
backportbot-nextcloud bot pushed a commit that referenced this issue Jan 13, 2022
@CarlSchwan @backportbot
Fix idn emails not working in shares
ca84575 
Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud bot pushed a commit that referenced this issue Jan 13, 2022
@CarlSchwan @backportbot
Fix idn emails not working in shares
c46c9e2 
Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud bot pushed a commit that referenced this issue Jan 13, 2022
@CarlSchwan @backportbot
Fix idn emails not working in shares
5e36c86 
Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan added a commit that referenced this issue Jan 13, 2022
@CarlSchwan
Fix idn emails not working in shares
2b2d23c 
And add check before sending email that email address is valid

Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan added a commit that referenced this issue Jan 13, 2022
@CarlSchwan
Fix idn emails not working in shares
e8f6e06 
And add check before sending email that email address is valid

Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan added a commit that referenced this issue Jan 13, 2022
@CarlSchwan
Fix idn emails not working in shares
2f10bc1 
And add check before sending email that email address is valid

Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
juliusknorr pushed a commit to nextmcloud/server that referenced this issue Feb 24, 2022
@CarlSchwan @juliusknorr
Fix idn emails not working in shares
8c72c40 
Fix nextcloud#30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug feature: sharing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix idn emails not working in shares nextcloud/server
1 participant
@PVince81