Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the loglevel of errors reported when parsing calendar subscriptions #31612

Closed
tcitworld opened this issue Mar 17, 2022 · 3 comments · Fixed by #31622
Closed

Increase the loglevel of errors reported when parsing calendar subscriptions #31612

tcitworld opened this issue Mar 17, 2022 · 3 comments · Fixed by #31622
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: caldav Related to CalDAV internals good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@tcitworld
Copy link
Member

tcitworld commented Mar 17, 2022 •
edited
Loading

Needs to go from debug to warning or info.

server/apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php

Line 255 in 6b4ab04

$this->logger->debug("Subscription $subscriptionId could not be parsed");

server/apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php

Line 265 in 6b4ab04

$this->logger->debug("Subscription $subscriptionId could not be parsed");

server/apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php

Line 276 in 6b4ab04

$this->logger->debug("Subscription $subscriptionId could not be parsed");

Originally posted by @thewavelength in nextcloud/calendar#2146 (comment)
@tcitworld tcitworld added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Mar 17, 2022
@tcitworld tcitworld added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 1. to develop Accepted and waiting to be taken care of feature: caldav Related to CalDAV internals and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Mar 17, 2022
tcitworld added a commit that referenced this issue Mar 18, 2022
@tcitworld
Increase loglevel of Webcal parsing errors and modernize code
2c7a883 
Closes #31612

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld mentioned this issue Mar 18, 2022
Merged
@pudasainimiraj
Copy link

Hello @tcitworld
I'd like to work on this issue. Is it closed yet?

@tcitworld
Copy link
Member Author

Unfortunately I've already taken care of it in #31622, as there's a few issues related to it.

@pudasainimiraj
Copy link

Thank you
I'll see some other open issues

tcitworld added a commit that referenced this issue May 12, 2022
@tcitworld
Increase loglevel of Webcal parsing errors and modernize code
41f0b07 
Closes #31612

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this issue May 13, 2022
@tcitworld
Increase loglevel of Webcal parsing errors and modernize code
5f9d64a 
Closes #31612

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this issue May 13, 2022
@tcitworld
Increase loglevel of Webcal parsing errors and modernize code
078e0bc 
Closes #31612

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this issue May 13, 2022
@tcitworld
Increase loglevel of Webcal parsing errors and modernize code
2e20227 
Closes #31612

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this issue May 17, 2022
@tcitworld
Increase loglevel of Webcal parsing errors and modernize code
741c443 
Closes #31612

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: caldav Related to CalDAV internals good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase loglevel of Webcal parsing errors and modernize code nextcloud/server
2 participants
@tcitworld @pudasainimiraj