Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipsize user name in top right #3273

Closed
jancborchardt opened this issue Jan 26, 2017 · 30 comments
Closed

Ellipsize user name in top right #3273

jancborchardt opened this issue Jan 26, 2017 · 30 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement

Comments

@jancborchardt
Copy link
Member

Currently there is no width limit on the username. This can lead to overlays with long names and narrow screens. For that we should either have a maximum width, or flexible so it automatically ellipsizes when the space gets narrow.

This is probably easy now with the switch to flexbox. Before it was a bit finnicky. cc @nextcloud/designers

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement labels Jan 26, 2017
@jancborchardt jancborchardt added this to the Nextcloud 12.0 milestone Jan 26, 2017
@skjnldsv skjnldsv self-assigned this Jan 26, 2017
@claell
Copy link

claell commented Jan 26, 2017

A different approach would be the following:

  • Currently the name is displayed when there is no image set.
  • Instead of showing the name one could display an image with the initials like in the settings where an image can be set.

@skjnldsv
Copy link
Member

I would agree to go avatar only in the case of a too narrow screen.
We could ellipsis for too long name but it could be great to go avatar for small screens

@claell
Copy link

claell commented Jan 26, 2017

Currently avatar will be always used when set, so why not have it also on larger screens when not set?

@skjnldsv
Copy link
Member

I don't know. This is a good question.
@nextcloud/designers what do you think?

@MorrisJobke
Copy link
Member

I don't know. This is a good question.
@nextcloud/designers what do you think?

Because we don't want to placeholder be there. The placeholder is okayish, but not super perfect ;)

@jancborchardt
Copy link
Member Author

We decided against this actually because then you have a colored placeholder there in the top right. And the color probably clashes with the Nextcloud blue, or theme color. That’s why we use a name.

@skjnldsv
Copy link
Member

This is indeed a good decision.
Thanks for the heads up @jancborchardt

@claell
Copy link

claell commented Jan 28, 2017

Thanks for explanation. Makes sense, if the colour of the placeholder avatar is random.

@skjnldsv
Copy link
Member

skjnldsv commented Feb 1, 2017

What about removing the user name and put it inside the dropdown menu on narrow screen?
We could use something like a setting icon instead?

@MariusBluem
Copy link
Member

MariusBluem commented Feb 1, 2017

What about removing the user name and put it inside the dropdown menu on narrow screen?
We could use something like a setting icon instead?

Wow. Nice idea @skjnldsv 👍 I thought about something like this, where you can also change your spreed/chat online status and maybe see your quota:

img_0409

@skjnldsv
Copy link
Member

skjnldsv commented Feb 1, 2017

This is amazing!! 😱😱😱😍😍

@skjnldsv
Copy link
Member

skjnldsv commented Feb 2, 2017

@MariusBluem Could you work on it? 😍

PS: are you associating administrators with a rotten apple? 😱 02-02_21-09-23

@MariusBluem
Copy link
Member

MariusBluem commented Feb 2, 2017

Could you work on it? 😍

I'd love to do ... bit I am really not an developer 😅😞
You see...its not a good idea to give a non-developer a iPad Pro with Pencil 😜

PS: are you associating administrators with a rotten apple? 😱

... I am at least not able to draw a gear 😒

@skjnldsv
Copy link
Member

skjnldsv commented Feb 2, 2017

Ahaha, so sorry! 😂
But it was a beautiful rotten apple though! 😆

@skjnldsv
Copy link
Member

skjnldsv commented Feb 6, 2017

So, what icon should we use as the menu-opener-button? :)

A rotten ap A setting icon?

@MorrisJobke
Copy link
Member

MorrisJobke commented Feb 7, 2017

A setting icon?

I only can find examples that use the avatar -.-

@eppfel
Copy link
Member

eppfel commented Feb 7, 2017

I'd go for a single-user icon. I mean it would duplicate with the personal menu item, but for non-admins, that is actually what the menu is for: profile (personal), help and logout.

@MariusBluem
Copy link
Member

A single-user icon would conflict with the contacts menu-icon which will be introduced with Nextcloud 12 ... @ChristophWurst - see #3233

@eppfel
Copy link
Member

eppfel commented Feb 7, 2017

Was not aware. What if we use a non-colored avatar then? There was a issue about changing the default avatars. Maybe we have to think this through more...

@skjnldsv
Copy link
Member

skjnldsv commented Feb 7, 2017

Ahahah, see #3273 (comment) @eppfel

@eppfel
Copy link
Member

eppfel commented Feb 8, 2017

I was referring to that comment. Therefore I particular propose a

non-colored avatar

Or am I lost here?

@skjnldsv
Copy link
Member

skjnldsv commented Feb 8, 2017

Hum, could be nice indeed!

@jancborchardt
Copy link
Member Author

Sooo this is a great idea -> can you open a separate issue for it @MariusBluem? :)

Because long usernames are still an issue and unrelated to this. Let's not derail the thread. ;)

@skjnldsv
Copy link
Member

Well, if we go for icon only then the long username will be irrelevant right?

@jancborchardt
Copy link
Member Author

Sorry but the top right should always be personalized. Either profile image or ellipsized name. No generic user icon because then you don't know immediately with which user you are logged in if you have multiple.

@skjnldsv
Copy link
Member

An avatar with fixed colour is a good idea though, and it will help fix nextcloud/notifications#60.

See @eppfel's comment

@jancborchardt
Copy link
Member Author

A non colored avatar has two issues:

  • We use colored avatar placeholders everywhere else. It’s confusing and not consistent.
  • It would be the first letter of the name. So basically how a name would look ellipsized on a small display. On big screens it’s fine though.

Think responsive, folks. ;) This is only an issue on small displays, on big screens it’s super nice how we do it. This is simply about ellipsizing long names correctly, nothing more and nothing less. :)

@skjnldsv
Copy link
Member

I honestly don't see the point of seeing my username on the header in my opinion. :)
But I can understand that people wants to.

Github just put the avatar for example, and without displaying the username.

@eppfel
Copy link
Member

eppfel commented Feb 23, 2017

I see it as @skjnldsv It is only relevant for multi accounts, which I believe to be the minority.

@MorrisJobke
Copy link
Member

This is fixed with #4074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement
Projects
None yet
Development

No branches or pull requests

6 participants