-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Impossible to confirm password during user creation #33637
Comments
possibly related to the v5.4.0 update of nextcloud-vue, which brought the focus trap for modals: nextcloud-libraries/nextcloud-vue#2654 |
then it's indeed the identical issue that we also had/have with Mail and v5.4 nextcloud/mail#7034 (review) |
there were additional fixes for modal focus trap which we might need to backport: nextcloud-libraries/nextcloud-vue#2955 nextcloud-libraries/nextcloud-vue#3020 |
the backports were merged, need to retry with stable5 of nextcloud-vue to see if the issue is fixed |
I've tested with stable5 with the fixes merged, but the problem persists I suspect this is due to having two modals on top of each other, maybe confusing the focus trap |
I tried upgrading the lib to 6.9.4 but it didn't help. I'll try to build a test case directly in nextcloud-vue, this way we can test and debug it there |
I suspect that we need to detect when the current modal is not focused any more and then pause the focus trap until we return to that modal. We currently don't have the semantics to know which modal is currently on top. |
Hmm, I created an example in nextcloud-libraries/nextcloud-vue#3087 and the focus trap works fine there. Next up:
|
I forgot we already had this ticket. Anyway, I made a new one moving forward: #33675 |
Bug description
^ this dialoge is unusable. I can't enter the password nor can I click a button.
Calling
OC.PasswordConfirmation.requirePasswordConfirmation()
after a fresh page load is usable. The confirmation dialogue only doesn't work when a modal is open.Steps to reproduce
Expected behavior
Password confirmation dialogue opens and I can use it
Installation method
No response
Operating system
No response
PHP engine version
No response
Web server
No response
Database engine version
No response
Is this bug present after an update or on a fresh install?
No response
Are you using the Nextcloud Server Encryption module?
No response
What user-backends are you using?
Configuration report
No response
List of activated Apps
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
No response
The text was updated successfully, but these errors were encountered: