Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Impossible to confirm password during user creation #33637

Closed
5 of 9 tasks
ChristophWurst opened this issue Aug 22, 2022 · 10 comments
Closed
5 of 9 tasks

[Bug]: Impossible to confirm password during user creation #33637

ChristophWurst opened this issue Aug 22, 2022 · 10 comments
Assignees
Milestone

Comments

@ChristophWurst
Copy link
Member

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Bildschirmfoto vom 2022-08-22 11-10-28

^ this dialoge is unusable. I can't enter the password nor can I click a button.

Calling OC.PasswordConfirmation.requirePasswordConfirmation() after a fresh page load is usable. The confirmation dialogue only doesn't work when a modal is open.

Steps to reproduce

  1. Log into Nextcloud as admin
  2. Wait x hours for the password confirmation to kick in (don't know the exact time)
  3. Open the user management
  4. Create a new user

Expected behavior

Password confirmation dialogue opens and I can use it

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

N/a

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@ChristophWurst ChristophWurst added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: users and groups regression accessibility labels Aug 22, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Aug 22, 2022
@PVince81 PVince81 added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 22, 2022
@PVince81
Copy link
Member

possibly related to the v5.4.0 update of nextcloud-vue, which brought the focus trap for modals: nextcloud-libraries/nextcloud-vue#2654

@ChristophWurst
Copy link
Member Author

then it's indeed the identical issue that we also had/have with Mail and v5.4 nextcloud/mail#7034 (review)

@PVince81
Copy link
Member

there were additional fixes for modal focus trap which we might need to backport: nextcloud-libraries/nextcloud-vue#2955 nextcloud-libraries/nextcloud-vue#3020

@PVince81
Copy link
Member

the backports were merged, need to retry with stable5 of nextcloud-vue to see if the issue is fixed

@PVince81
Copy link
Member

I've tested with stable5 with the fixes merged, but the problem persists

I suspect this is due to having two modals on top of each other, maybe confusing the focus trap

@PVince81
Copy link
Member

yeah... I see that the focus is still on the modal behind and not in the new modal... you can still tab onto the fields...

image

@PVince81
Copy link
Member

I tried upgrading the lib to 6.9.4 but it didn't help.

I'll try to build a test case directly in nextcloud-vue, this way we can test and debug it there

@PVince81 PVince81 self-assigned this Aug 22, 2022
@PVince81
Copy link
Member

I suspect that we need to detect when the current modal is not focused any more and then pause the focus trap until we return to that modal. We currently don't have the semantics to know which modal is currently on top.

@PVince81
Copy link
Member

Hmm, I created an example in nextcloud-libraries/nextcloud-vue#3087 and the focus trap works fine there.
Either there are more changes on master / nc vue 6.0.0 or it's the way how the dialog is invoked that is different.

Next up:

@PVince81
Copy link
Member

I forgot we already had this ticket.

Anyway, I made a new one moving forward: #33675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants