-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port password confirmation dialog to vue #33675
Port password confirmation dialog to vue #33675
Comments
I've added this to #32117 to warn that this kind of scenario won't work any more. |
original issue was here: #33637 |
Since this is in Vue I would say we should port this to https://github.com/nextcloud/nextcloud-vue to benefit from the consolidated effort of our Vue build system There is also this js-only wrapper lib https://github.com/nextcloud/nextcloud-password-confirmation which we could use as a starting point but would splinter off from the https://github.com/nextcloud/nextcloud-vue build system What do you think @CarlSchwan @nickvergessen @PVince81? |
I'm fine with making nextcloud-password-confirmation depend on nextcloud-vue |
Steps
Expected result
Password can be entered.
Actual result
The password prompt appears but cannot be focussed, because the focus trap is still on the parent dialog, which itself uses Vue.
The password prompt itself is not using Vue, so the focus trap interaction cannot work.
With the update of nextcloud-vue and the introduction of a focus trap for vue-based dialogs, old dialogs like this one cannot work correctly as the focus trap will remain on the old dialog.
To make this work correctly, we need to port the password confirmation dialog to Vue: https://github.com/nextcloud/server/blob/update-nextcloud-vue-6.0.0-beta.2/core/src/OC/password-confirmation.js#L90
We need to do this anyway in general to make the dialog follow accessibility standards.
The text was updated successfully, but these errors were encountered: