Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port password confirmation dialog to vue #33675

Closed
PVince81 opened this issue Aug 24, 2022 · 4 comments · Fixed by nextcloud-libraries/nextcloud-password-confirmation#378
Closed
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug
Milestone

Comments

@PVince81
Copy link
Member

Steps

  1. Check out Bump @nextcloud/vue to 6.0.0-beta.4 and related #33516 (if not merged yet)
  2. Go to users page
  3. Create a new user
  4. Add a password
  5. Click "Add new user"
  6. Enter your password in the prompt that appears

Expected result

Password can be entered.

Actual result

The password prompt appears but cannot be focussed, because the focus trap is still on the parent dialog, which itself uses Vue.
The password prompt itself is not using Vue, so the focus trap interaction cannot work.

With the update of nextcloud-vue and the introduction of a focus trap for vue-based dialogs, old dialogs like this one cannot work correctly as the focus trap will remain on the old dialog.

To make this work correctly, we need to port the password confirmation dialog to Vue: https://github.com/nextcloud/server/blob/update-nextcloud-vue-6.0.0-beta.2/core/src/OC/password-confirmation.js#L90

We need to do this anyway in general to make the dialog follow accessibility standards.

@PVince81
Copy link
Member Author

I've added this to #32117 to warn that this kind of scenario won't work any more.

@PVince81
Copy link
Member Author

original issue was here: #33637

@Pytal
Copy link
Member

Pytal commented Aug 25, 2022

Since this is in Vue I would say we should port this to https://github.com/nextcloud/nextcloud-vue to benefit from the consolidated effort of our Vue build system

There is also this js-only wrapper lib https://github.com/nextcloud/nextcloud-password-confirmation which we could use as a starting point but would splinter off from the https://github.com/nextcloud/nextcloud-vue build system

What do you think @CarlSchwan @nickvergessen @PVince81?

@nickvergessen
Copy link
Member

I'm fine with making nextcloud-password-confirmation depend on nextcloud-vue
Sounds like the best way forward if we don't want to have it in server/core directly which would also be fine for me.

@Pytal Pytal added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Aug 27, 2022
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants