Theme background is bleeding through at the bottom

[juliusknorr]

• BUG: theme background is bleeding through at the bottom (I've changed the theme color to orange)

Originally posted by @PVince81 in #33568 (comment)

[juliusknorr]

I also cannot reproduce, browser in would be interesting and if it is still an issue

[skjnldsv]

I have a similar issue, with a custom primary (red) sometimes it flashes when I click.
When there is a primary, shouldn't we disable the background? Same as we do for the login with the apps-pattern background image?

[jancborchardt]

When there is a primary, shouldn't we disable the background?

@skjnldsv no – there always is a primary color, so we would always have to disable it? People can choose "Plain background" for this reason:

Same as we do for the login with the apps-pattern background image?

@skjnldsv The login page background image should actually be switched from the apps-pattern background to the "clouds" we use by default for the Dashboard. We discussed this in the call, and I thought I also noted it down – added it to #33736

• Login page default background needs to switch from the "icons" background to the "clouds" background
• Theming "Login image" needs to be changed to "Background image" and taken as default for the login page as well as people’s background image – until they change it

[jancborchardt]

Ah I think what I mentioned before is actually what @juliushaertl filed at #33797, is that correct?

[jancborchardt]

(And even more so, @GretaD’s pull request at #33733 :)

[szaimen]

• BUG: theme background is bleeding through at the bottom (I've changed the theme color to orange)

Originally posted by @PVince81 in #33568 (comment)

cannot reproduce. Which browser was it?

[skjnldsv]

@jancborchardt so you're ok having huge primary flash before loading an image that have a completely different colour ?

Peek.06-09-2022.11-24.mp4

[skjnldsv]

I guess this is a conflict between admin and user config.
I think we should revisit the default settings image from dashboard. If as an admin, I set a custom primary, I fully expect my users to have that colour being used. Not the default cloud background, don't you think?

[jancborchardt]

@jancborchardt so you're ok having huge primary flash before loading an image that have a completely different colour ?

@skjnldsv no for sure not. :) We could probably set the background to color-main-background instead?

[jancborchardt]

I guess this is a conflict between admin and user config.
I think we should revisit the default settings image from dashboard. If as an admin, I set a custom primary, I fully expect my users to have that colour being used. Not the default cloud background, don't you think?

Right, now I get what you mean. Yes we need a matrix of decisions:

• If all is default, all is good like it is.
• If the admin customizes anything and the individual person does not change the background, then the admin theming takes precedence
  • If a different color is set, it should still show the admin-set image though. Only if the admin deletes the image, the color-only should be taken.
• If the individual person changes the background from default, then we take their chosen background no matter what the admin did.
  • Additionally we need to use color-main-background as the whole background color to prevent the color flash.
  • Alternatively we could assign a primary color for each of the dashboard images which is taken as primary? Would only work for those preset ones, but I could quickly go through and do that? Thinking about this, it's too complex for little benefit? color-main-background will work for now, and with 26 or so ideally we compute a primary from the image, like Material You?

[skjnldsv]

Thank you, It helps knowing to where to move forward :)

[jancborchardt]

@skjnldsv new issue with more detail on this after talking about it with @karlitschek: #33925

[Pytal]

Cannot reproduce the bleeding at the bottom

Flashing background addressed in #34204

[nextcloud-command]

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.