⚗️ Proof of concept: Redesign app-content #33568
Conversation
AndyScherzinger
changed the title
juliusknorr
force-pushed
the
poc/redesign
branch
2 times, most recently
from
30d180c to
47a2534
Compare
juliusknorr
force-pushed
the
poc/redesign
branch
from
f62a9d3 to
be03214
Compare
nickvergessen
added
1. to develop
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
juliusknorr
force-pushed
the
poc/redesign
branch
2 times, most recently
from
013d926 to
fe5223d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
juliusknorr
force-pushed
the
poc/redesign
branch
from
7caefbf to
cc8a0d4
Compare
|
FYI @raimund-schluessler @jotoeri @tcitworld @tacruc @Rello since you are very active in the Vue components and/or in app development, it would be awesome if you can test this! :) Then we can make sure to adjust stuff that doesn’t work yet. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Before it was checked if the new user form was visible, but it was not waited for it. It seems that it can happen that the new user form is in the DOM, and therefore found, but not visible yet when the tests run, which caused them to (randomly) fail. Due to that now it is explicitly waited until it is visible, rather than assuming that it is visible as soon as it appears in the DOM. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
By the default the browser window is not maximized, but opened with a size of 1050x978px. In the Files app, when the navigation bar and the side bar are both open, with the previous design that width caused the file name to be very very narrow, but still clickable. However, with the updated design the file name is too narrow and no longer clickable, which breaks several acceptance tests that descend into subfolders. To solve that now the browser window is maximized before running the tests, which makes the window wide enough (1360px) to show the file name and make it clickable. This commit also removes a step to close the sidebar that was recently added to address the problem mentioned above in a previous pull request. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
|
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
poc/redesign
branch
from
f6e2e87 to
5219992
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
Seems one additional failure at features/app-files-sharing.feature:422 but passes locally. @danxuliu Shall we also consider that unrelated? |
Yes, I guess that the problem is that sometimes the share menu is not properly opened and therefore the item can not be found (which is probably the same underlying issue as in |
|
Thanks for checking that. All other failures seem unrelated. |
|
Will take care of filing the reportings into follow up tickets. |
|
When opening a photo in Photos Sidebar.vue:464 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'classList')
at o.setFullScreenMode (Sidebar.vue:464)
at a.beforeOpen (Viewer.vue:449)
at Viewer.vue:460
at u (runtime.js:63)
at Generator._invoke (runtime.js:294)
at Generator.next (runtime.js:119)
at jg (Pencil.vue?12b8:19)
at a (Pencil.vue?12b8:19)
at Pencil.vue?12b8:19
at new Promise (<anonymous>)EDIT: FIX in #33814 |
|
Filed all inline reportings with the https://github.com/nextcloud/server/labels/ui-refresh-feedback |
ToDo
Issues with moving body scroll to a scrollable element for main content
Follow ups
BUG: Notification menu is missing arrow indicator(already present before the rework) Arrow missing from popover notifications#1267Test matrix for non-vue or server apps
Screenshots