[Bug]: Internal server error after upgrade to NC25beta: Typed property OC\Files\Storage\Wrapper\Quota::$quota must be int or null, float used in file #34010
Comments
lars-becker
added
0. Needs triage
This comment was marked as outdated.
This comment was marked as outdated.
Change the quota to int from float, since the quota is a number of bits and a bits can not be splitted. Fix #34010 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Change the quota to int from float, since the quota is a number of bits and a bits can not be splitted. Fix #34010 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Change the quota to int from float, since the quota is a number of bits and a bits can not be splitted. Fix #34010 Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
Thanks for the quick fix. I applied the patch and everything works as expected. |
Thanks for testing 😀 |
|
Is it possible, that this fix broke 32-bit compatibility again? I just upgraded to 25.0.2 on my ARMv7 server (32 bit) and got this error: Changing the type of quota from int to float in Files/Storage/Wrapper/Quota.php seems to fix the problem. |
|
+1 same for me |
|
could you please post what did you change; filenames, nr. of line and the edited content - it what be very helpful! |
|
TypeError: Cannot assign float to property OC\Files\Storage\Wrapper\Quota::$quota of type ?int |
I changed following lines and it worked out for me. Referring to following code: Line 44: protected ?int $quota; -> ?int to ?float |
|
i changed following lines and it worked for me too (based on this post: /legacy/OC_Helper.php lib/private/legacy/OC_Util.php I didn't change "/private/Files/Storage/Wrapper/Quota.php" at all! thanks a lot for your quick replays! |
this one solved it for me! |
|
can you confirm if #35734 is enough on top of 25.0.2 to fix the quota issues on 32-bit systems ? |
|
the quota issue on my 32-bit system (raspbian/pi4) got fixed by executing following steps: /legacy/OC_Helper.php lib/private/legacy/OC_Util.php |
|
I upgraded today to "Nextcloud Hub 3 (25.0.2)" via Stable Channel and also get this error now. Running NC on a Raspi 3b. Can confirm, that the fix is working. |
|
I've updated the patch for 25.0.2, please check if it #35734 (comment) |
|
Sorry for not replying earlier. Busy times... and the return type of the method getQuota() from int to float That has solved the immediate issue on my 32 bit system and I haven't observed any side effects so far. Neither have I tried whether changing both lines is actually necessary. I was simply happy the instance was running again since I currently don't have the bandwidth to deal with a broken cloud. BTW, I'm not a php programmer. Please excuse if I may have used wrong terminology. |
|
Seeing this in the logs when a users tries to access NC using the iOS app. No Quota and NO FILES are shown in the app. Maybe a 32/64 bit thing (I am already running NC 25.0.2)?
|
Those two changes indeed made the quota load again for my users so they could actually see content in their iOS NC apps again and upload stuff using WebDAV. Gosh that 32 bit thing... luckily clock is ticking, but releasing NC v25 for 32 bit was a huuuuuuuuge mistake, obviously. When users try to load gallery view in the app I see plenty of those in the logs, is there a issue for that one too? Other 32 bit users should suffer from this too right?
|
Also change line 71 |
Bug description
After an upgrade to NC25 Beta 6 from NC24 Nextcloud throws an 500 internal server error for logged in users. I switched the debug level to 0, but wasn't unable to finde more information than this trace which doesn't help me to get an idea, what might trigger the problem.
Steps to reproduce
Haven't tried to reproduce it on other instances. Error occured directly after installing Beta5 with the web installer. Tried to upgrade to Beta6 with a manual upgrade. Nothing changed.
Expected behavior
200 OK instead of 500 Internal Server Error.
Installation method
Community Manual installation with Archive
Operating system
Debian/Ubuntu
PHP engine version
PHP 7.4
Web server
Nginx
Database engine version
MySQL
Is this bug present after an update or on a fresh install?
Updated to a major version (ex. 22.2.3 to 23.0.1)
Are you using the Nextcloud Server Encryption module?
No response
What user-backends are you using?
Configuration report
{ "system": { "maintenance": false, "config_is_read_only": false, "installed": true, "version": "25.0.0.11", "share_folder": "\/Shared\/", "sharing.maxAutocompleteResults": 50, "sharing.minSearchStringLength": 2, "sharing.enable_share_accept": true, "memcache.local": "\\OC\\Memcache\\APCu", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 6379 }, "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "dbname": "***REMOVED SENSITIVE VALUE***", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbtableprefix": "oc_", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "forcessl": true, "blacklisted_files": [ ".htaccess" ], "theme": "", "default_language": "de", "3rdpartyroot": "", "3rdpartyurl": "", [44/384] "defaultapp": "apporder", "knowledgebaseenabled": false, "knowledgebaseurl": "https:\/\/api.owncloud.com\/v1", "appstoreenabled": true, "appstoreurl": "https:\/\/apps.nextcloud.com\/api\/v1", "activity_expire_days": 186, "mail_smtpdebug": false, "mail_smtpmode": "sendmail", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "25", "mail_smtptimeout": 10, "mail_smtpauthtype": "LOGIN", "trashbin_retention_obligation": "180, auto", "versions_retention_obligation": "30,auto", "allow_user_to_change_display_name": true, "appcodechecker": true, "updatechecker": true, "log_type": "file", "logfile": "\/tmp\/nextcloud.log", "logfilemode": 416, "loglevel": 0, "syslog_tag": "Nextcloud", "remember_login_cookie_lifetime": 1209600, "session_lifetime": 86400, "xframe_restriction": true, "apps_paths": [ { "path": "\/var\/www\/nextcloud\/apps\/", "url": "\/apps", "writable": true } ], "customclient_desktop": "", "customclient_android": "", "customclient_ios": "", "instanceid": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "***.org" ], "appstore.experimental.enabled": true, "debug": true, "log_rotate_size": 1048576, "singleuser": false, "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mysql.utf8mb4": true, "updater.release.channel": "beta", "preview_libreoffice_path": "\/usr\/bin\/libreoffice", "enable_previews": true, "preview_max_x": 800, "preview_max_y": 800, "enabledPreviewProviders": [ "OC\\Preview\\PNG", "OC\\Preview\\JPEG", "OC\\Preview\\GIF", "OC\\Preview\\HEIC", "OC\\Preview\\BMP", "OC\\Preview\\XBitmap", "OC\\Preview\\MP3", "OC\\Preview\\TXT", "OC\\Preview\\MarkDown", "OC\\Preview\\OpenDocument", "OC\\Preview\\Krita", "OC\\Preview\\MSOffice2003", "OC\\Preview\\MSOffice2007", "OC\\Preview\\MSOfficeDoc", "OC\\Preview\\PDF", "OC\\Preview\\Postscript", "OC\\Preview\\StarOffice", "OC\\Preview\\SVG", "OC\\Preview\\Font" ], "twofactor_enforced": "false", "twofactor_enforced_groups": [], "twofactor_enforced_excluded_groups": [], "skeletondirectory": "", "app_install_overwrite": { "25": "bbb" }, "overwrite.cli.url": "https:\/\/***.org", "data-fingerprint": "7921b76ed34d1840b29754d584250194", "logtimezone": "Europe\/Berlin", "activity_use_cached_mountpoints": true, "has_rebuilt_cache": true, "simpleSignUpLink.shown": true, "default_phone_region": "DE", "updater.secret": "***REMOVED SENSITIVE VALUE***" } }List of activated Apps
Nextcloud Signing status
No response
Nextcloud Logs
Additional info
No response
The text was updated successfully, but these errors were encountered: