Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New share icon in breadcrumb nav #3564

Closed
te-online opened this issue Feb 21, 2017 · 5 comments
Closed

New share icon in breadcrumb nav #3564

te-online opened this issue Feb 21, 2017 · 5 comments
Labels
design Design, UI, UX, etc. enhancement feature: files feature: sharing papercut Annoying recurring issue with possibly simple fix.

Comments

@te-online
Copy link
Contributor

The new share icon in the breadcrumb navigation was probably meant to speed up everyones workflow. As a user I have to say that I find it very confusing.

bildschirmfoto 2017-02-21 um 16 12 17
not shared folder

bildschirmfoto 2017-02-21 um 16 12 35
shared folder

My points of criticism being:

  • The difference between the shared/not shared state is not big enough. The not-shared state looks like the shared state if no comparison is available. I panicked seeing this the first time, thinking the folder was shared.
  • Why is the icon only shown for the current folder? This fact could support the confusion, because not every folder in the hierarchy has the icon, which could suggest that this particular folder is shared – while it's not (this scenario is not visible in the screenshots).
  • When I click on the icon I get to the details panel of the folder I'm currently in. This icon is the only option to get there from within the folder. But there are other tabs in the panel (comment, activities). How should a user reach them from inside the folder? It seems inconsistent to provide an icon for one action, but not for all of them.

My suggestion:
Well, I don't have one at the moment. Personally, I see this as a big cause of confusion within the interface, because of the three inconsistencies mentioned. I'm interested, if anyone agrees to that – or if maybe someone might be able to come up with a solution (that is not removing the icon again).

@MorrisJobke
Copy link
Member

cc @nextcloud/designers

@MorrisJobke MorrisJobke added the papercut Annoying recurring issue with possibly simple fix. label Aug 15, 2017
@jancborchardt
Copy link
Member

jancborchardt commented Aug 15, 2017

The difference between the shared/not shared state is not big enough. The not-shared state looks like the shared state if no comparison is available. I panicked seeing this the first time, thinking the folder was shared.
Agree.

  • We’re experimenting with adding avatars into the files list for shared elements: Show avatar instead of username for shared files #6094 – we should add them to the top there too in the future.
  • Another thing we could do is for non-shared folders, instead of the share icon, show the 3-dot icon. The 3-dot icon would also open the sidebar, but the icon would be less confusing. Might be a very good quick fix. That would also solve your last point, at least for the initial run.

Why is the icon only shown for the current folder? This fact could support the confusion, because not every folder in the hierarchy has the icon, which could suggest that this particular folder is shared – while it's not (this scenario is not visible in the screenshots).

Simply out of space reasons. But the spec was always that the breadcrumbs also show if a parent folder is indeed shared, as an indicator.

jancborchardt added a commit that referenced this issue Aug 15, 2017
fix #3564

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member

Pull request to change the default icon to icon-more (3-dots) at #6143 :)

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2017

Actually I don't really mind the icon, I think the opacity is different enough to understand it.

When I click on the icon I get to the details panel of the folder I'm currently in. This icon is the only option to get there from within the folder. But there are other tabs in the panel (comment, activities). How should a user reach them from inside the folder? It seems inconsistent to provide an icon for one action, but not for all of them.

But for this, I think this is a big issue.
We should indeed definitely add an icon or a way to open the right sidebar.
@nextcloud/designers

@jancborchardt
Copy link
Member

I am really hesitant to add a different icon here.

  • The icon-more doesn’t work cause we use that so often already, it’s at a danger of overuse.
  • The icon-info we could do, but we also want to use the share-indicator for other folders in the breadcrumb dropdown in the future
  • Icon-activity we don’t really use anywhere there and it would duplicate the app icon

Unless the issue is more pressing or we come up with a really good solution, I would say we close this?

Also, the change to possibly show the sidebar by defaut on big screens will make this less of an issue: #7138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design, UI, UX, etc. enhancement feature: files feature: sharing papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants