Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression when renaming incoming shares #36153

Closed
juliusknorr opened this issue Jan 16, 2023 · 4 comments · Fixed by #36161
Closed

Regression when renaming incoming shares #36153

juliusknorr opened this issue Jan 16, 2023 · 4 comments · Fixed by #36161
Assignees
@icewind1991
Labels
1. to develop Accepted and waiting to be taken care of 25-feedback 26-feedback bug regression
Milestone
Nextcloud 25.0.3

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Jan 16, 2023 •
edited
Loading

There seems to be a regression from #36047 where renaming shares is not working properly anymore.

Steps to reproduce:

  • Share a file from A to B
  • Login as B
  • Rename the file
  • Reload the file list

Expected:

  • The new name should be shown

Actual:

  • The old name is still shown

cc @icewind1991 @PVince81
@szaimen szaimen added 0. Needs triage Pending check for reproducibility or if it fits our roadmap 24-feedback 25-feedback 26-feedback labels Jan 16, 2023
@PVince81
Copy link
Member

I've switched memcache.local to redis to be able to inspect the key

from what I see the cached value still has the old path name

it seems we're missing some invalidation code, however I'm not sure how it could have worked before...

@PVince81 PVince81 added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 16, 2023
@PVince81 PVince81 added this to the Nextcloud 25.0.3 milestone Jan 16, 2023
@PVince81
Copy link
Member

PR here: #36159

This was referenced Jan 16, 2023
Merged
Closed
@PVince81
Copy link
Member

ok, so the reason it worked before was because the share target changed, so this made it use a different cache key
after each rename

@PVince81
Copy link
Member

better PR here: #36161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icewind1991 icewind1991

Labels
1. to develop Accepted and waiting to be taken care of 25-feedback 26-feedback bug regression
Projects
None yet
Milestone
Nextcloud 25.0.3
Development

Successfully merging a pull request may close this issue.

still include the share target in the cache key for validating share mount nextcloud/server
4 participants
@PVince81 @icewind1991 @juliusknorr @szaimen