Invalidate share mount cache when renaming #36159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
The cachekey previously included the target, so renaming it would cause a cache miss. An alternative solution would be to have the cachekey include both the share id and target but I'm not sure if there is a real advantage for that over this sollution |
|
Fixes #36153 |
|
Text CI proves that this fixes the issue https://github.com/nextcloud/text/actions/runs/3930365122/jobs/6720297719 |
|
closing in favor of #36161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Notes
It is still unclear why it worked before, which means this fix might be the wrong approach.