Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: the display does not change when clicking on a favorite in Files #38503

Closed
5 of 9 tasks
Tracked by #2686
maximelehericy opened this issue May 29, 2023 · 14 comments
Closed
5 of 9 tasks
Tracked by #2686
Assignees

Comments

@maximelehericy
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

see title

Steps to reproduce

click on a favorite.
display should show the content of your favorite folder.
nothing happens, but the URL changes.

Expected behavior

display should show the content of your favorite folder.

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

c.nc.c

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@maximelehericy maximelehericy added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap regression 27-feedback labels May 29, 2023
@szaimen
Copy link
Contributor

szaimen commented May 29, 2023

cc @nextcloud/server-frontend

@skjnldsv
Copy link
Member

Clicking where, in the files list? In the navigation?

@szaimen
Copy link
Contributor

szaimen commented Jun 1, 2023

Apparently @Rello can reproduce this as well.

Possibly caused by #38441?

@Rello
Copy link
Contributor

Rello commented Jun 1, 2023

yes. FF; c.n.c;
2 issues here - see the video:

Navigation bar link not working

  • click on a favorite folder underneath the "Favorites" navigation item => nothing happnes
  • click on "Favorites" navigation item first and then the favorite folder in the navigation bar => it works

Listview only working on second click

  • click on "Favorites" navigation item and then the favorite folder in the file list => Breadcrumb changes, but home file list is displayed
  • click on the breadcrumb again - the correct folder content is shown
Bildschirmaufnahme.2023-06-01.um.09.54.37.mov

@skjnldsv skjnldsv self-assigned this Jun 6, 2023
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 6, 2023
@arnowelzel
Copy link
Contributor

JFTR: Happens here as well with a server I just upgraded from NC 26.0.3 to NC 27.0.0. It does not matter which browser I use and I have to explain nearly 40 users that the favorites are not usable any longer until this I fixed. Wasn't there a E2E test to make sure that works before releasing a new version?

@ernolf
Copy link
Contributor

ernolf commented Jun 23, 2023

JFTR: I have to explain nearly 40 users that the favorites are not usable any longer until this I fixed.

Favorites are still usable. Workaround:

  • Click ON Favorites, (not on the expand [>]/[v] button):

  • the Favorites are listed in main window, where you can click and open them.

@arnowelzel
Copy link
Contributor

arnowelzel commented Jun 23, 2023

JFTR: I have to explain nearly 40 users that the favorites are not usable any longer until this I fixed.

Favorites are still usable. Workaround:

  • Click ON Favorites, (not on the expand [>]/[v] button):
  • the Favorites are listed in main window, where you can click and open them.

Thanks for the hint - I also found that out meanwhile ;-)

Maybe I'll add some custom CSS as a tempory fix to hide the favorite list on the left and the expand button until a fix is provided.

@szaimen
Copy link
Contributor

szaimen commented Jun 28, 2023

Cc @nextcloud/server-frontend should we try to fix this for 27.0.1?

@YouveGotMeowxy
Copy link

Came her just to report this issue on mine as well. Latest NC version in docker. I click any favoring in the menu and the url in the location bar changes, but the page itself doesn't do anything. I have to press the enter button after clicking it so it actually navigates to that page.

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jul 11, 2023
@szaimen
Copy link
Contributor

szaimen commented Jul 14, 2023

Fixed with #39301

@samhonarvar
Copy link

It seems like this was fixed in July 14, I'm running 27.1.2 and this issue is still happening for me.

@CuriousHummingbird
Copy link

CuriousHummingbird commented Nov 23, 2023

Same here with 27.1.3. the Bug ist still there... Our additional problem is, that the workaround above does not work if you use the favorites for copying and moving files within the NextCloud folders in the popup windows. The folder view is loading and does not show any results after the first click on any favorites Folder in the popup window, when using the existing favorites.

NCFavBug-2023-11-23_11.55.28.mp4

@surfrock66
Copy link

Following up on this, on Nextcloud Hub 8 (29.0.5) with all apps up to date, the links in my favorites no longer work, and instead I get an error "No Favorites Yet".

If I navigate to my root, and go to my folder, I can see all my contents:

image

If I click the link in the favorites on the sidebar, I get the following:

image

This was working as recently as last week, and this is the same for all favorites. Speculating, can it not find the path because the root of "Favorites" isn't tracing properly to the actual root path of the share?

@hegGK
Copy link

hegGK commented Sep 10, 2024

Same here! Also 29.0.5 and the Favorite menu entry seems to filter the path:
image
instead of being a link to a normal folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests